Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated setuptools to v.71 to fix a security issue #129

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Jul 18, 2024

Description

Fixed

How to test

  • Deploy and start locally
  • Make sure the image is pushed to Docker Hub

Review

  • Tests executed by CR
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (ef00987) to head (7969c34).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   95.02%   95.30%   +0.28%     
==========================================
  Files          11       11              
  Lines         462      490      +28     
==========================================
+ Hits          439      467      +28     
  Misses         23       23              
Flag Coverage Δ
unittests 95.30% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

After upgrading the lib it is launching as expected:

image

And it's pushed to Docker Hub:

image

@northwestwitch northwestwitch merged commit f153cf0 into main Jul 18, 2024
7 checks passed
@northwestwitch northwestwitch deleted the upgrade_setuptools_v70 branch November 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address security issue in setuptools < 70.0
2 participants