Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Validate and add another endpoint to check the validation errors of a demo submission #123

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Apr 26, 2024

This PR adds | fixes:

  • Add an endpoint /apitest-status that returns a response containing a link to the eventual json file with the submissions data errors

How to test:

  • Try the /apitest-status endpoint with the api key and the id of a submission already posted to the ClinVar apitest

Expected outcome:

  • The response should visualize the actions with eventual errors

Review:

  • Code approved by
  • Tests executed by CR, GitHub actions

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (ef00987) to head (ab870f7).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   95.02%   95.16%   +0.14%     
==========================================
  Files          11       11              
  Lines         462      476      +14     
==========================================
+ Hits          439      453      +14     
  Misses         23       23              
Flag Coverage Δ
unittests 95.16% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

Tested locally:

image

@northwestwitch northwestwitch merged commit 9fde665 into main Apr 26, 2024
7 checks passed
@northwestwitch northwestwitch deleted the submission_status branch April 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants