Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand validate output to display link for downloading json with submission errors #121

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Apr 26, 2024

This PR adds | fixes:

@dnil FIY

How to test:

  • Use validate endpoint with a submission that you know contains errors

Expected outcome:

  • The json data returned from ClinVar should return a link to download the file with the submission data analysis

Review:

  • Code approved by
  • Tests executed by CR

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (ef00987) to head (9cd2ab5).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   95.02%   95.10%   +0.08%     
==========================================
  Files          11       11              
  Lines         462      470       +8     
==========================================
+ Hits          439      447       +8     
  Misses         23       23              
Flag Coverage Δ
unittests 95.10% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

Tested locally: ✅

image

@northwestwitch northwestwitch changed the title Expand validate output to display link for doenloading json with submission errors Expand validate output to display link for downloading json with submission errors Apr 26, 2024
@northwestwitch northwestwitch merged commit d59cb0d into main Apr 26, 2024
7 checks passed
@northwestwitch northwestwitch deleted the improve_validate branch April 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change validate endpoint to show detailed submission errors
2 participants