Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API submission schema with latest schema from ClinVar #108

Merged
merged 15 commits into from
Mar 14, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Mar 14, 2024

This PR adds | fixes:

  • Updated submission schema to the latest provided by ClinVar

How to test:

  • All automatic tests should pass

Review:

  • Tests executed by GitHub actions

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (846cec9) to head (ede6e58).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   95.12%   94.84%   -0.29%     
==========================================
  Files          10       11       +1     
  Lines         431      446      +15     
==========================================
+ Hits          410      423      +13     
- Misses         21       23       +2     
Flag Coverage Δ
unittests 94.84% <100.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch marked this pull request as ready for review March 14, 2024 10:22
@northwestwitch northwestwitch merged commit 06ddc8c into main Mar 14, 2024
8 checks passed
@northwestwitch northwestwitch deleted the update_schema branch March 14, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants