Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept new column names for clinsig: Germline classification and Comment on classification #102

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Feb 9, 2024

This PR adds | fixes:

How to test:

  • Automatic tests

Expected outcome:

  • All tests should pass

Review:

  • Code approved by
  • Tests executed by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (846cec9) 95.12% compared to head (e69fb3a) 95.15%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   95.12%   95.15%   +0.02%     
==========================================
  Files          10       10              
  Lines         431      433       +2     
==========================================
+ Hits          410      412       +2     
  Misses         21       21              
Flag Coverage Δ
unittests 95.15% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch merged commit e0a52b5 into main Feb 9, 2024
7 checks passed
@northwestwitch northwestwitch deleted the fix_fields_renaming branch February 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants