Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(crud and models) #99

Merged
merged 5 commits into from
Mar 12, 2024
Merged

refactor(crud and models) #99

merged 5 commits into from
Mar 12, 2024

Conversation

ChrOertlin
Copy link
Contributor

Added

Refactors the crud of the database and moves models into a more appropriate space.

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner March 7, 2024 15:17
henrikstranneheim
henrikstranneheim approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

genotype_api/api/endpoints/samples.py Outdated Show resolved Hide resolved
This was linked to issues Mar 8, 2024
Refactor CRUD under store namespace #91
Closed
Refactor SQL models under store namespace #93
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ChrOertlin
Copy link
Contributor Author

Tested on stage
image

@ChrOertlin
Copy link
Contributor Author

Ignoring sonarcloud - pionts to a model as being duplicated, names differ though

@ChrOertlin ChrOertlin merged commit c7bcaf1 into main Mar 12, 2024
2 of 3 checks passed
@ChrOertlin ChrOertlin deleted the refactor-crud branch March 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikstranneheim henrikstranneheim henrikstranneheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor SQL models under store namespace Refactor CRUD under store namespace
2 participants
@ChrOertlin @henrikstranneheim