Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(poetry support) #98

Closed
wants to merge 4 commits into from
Closed

add(poetry support) #98

wants to merge 4 commits into from

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Mar 7, 2024

Added

Adds poetry support for managing package dependencies.

During setup of poetry a dependency issue was found between:
sql alchemy and sqlmodels
The previously locked version of sqlalchemy to 1.4 could not resolve sqmodel 0.0.16.

closes. #83

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner March 7, 2024 13:29
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, 👍 . I think we also can remove the setup file ( changes also needed then in bumpconfig). I guess I need to merge #96 first.

requirements-dev.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 8, 2024 10:20 Inactive
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@clingen-sthlm clingen-sthlm temporarily deployed to stage March 8, 2024 12:32 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 8, 2024 13:35 Inactive
@henrikstranneheim
Copy link
Contributor

Would be great to also let the actions use poetry to get rid of requirements files.

      - name: Install and configure Poetry
        uses: snok/install-poetry@v1
        with:
          virtualenvs-create: false

@clingen-sthlm clingen-sthlm temporarily deployed to stage March 11, 2024 08:30 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage March 12, 2024 10:42 Inactive
@ChrOertlin
Copy link
Contributor Author

Will first update pydantic

@ChrOertlin
Copy link
Contributor Author

closing in favor of #126

@ChrOertlin ChrOertlin closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants