Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pydantic) #81

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fix(pydantic) #81

merged 3 commits into from
Mar 6, 2024

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Mar 5, 2024 •
edited
Loading

Added

Changed

Fixed

  • Missing imports

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim
Copy link
Contributor Author

API 👍

Screenshot 2024-03-05 at 16 05 55

@henrikstranneheim henrikstranneheim marked this pull request as ready for review March 5, 2024 15:15
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner March 5, 2024 15:15
@henrikstranneheim henrikstranneheim added the Bug Something isn't working label Mar 5, 2024
ChrOertlin
ChrOertlin approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@henrikstranneheim henrikstranneheim merged commit 3b9d944 into main Mar 6, 2024
2 of 3 checks passed
@henrikstranneheim henrikstranneheim deleted the fix-pydantic-import branch March 6, 2024 08:18
islean
islean approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So new ones are email-validator and python-multipart and requests?

@henrikstranneheim
Copy link
Contributor Author

and pydantic

@henrikstranneheim
Copy link
Contributor Author

Deployed in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

@ChrOertlin ChrOertlin ChrOertlin approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrikstranneheim @ChrOertlin @islean