Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(black) #79

Merged
merged 6 commits into from
Mar 6, 2024
Merged

feat(black) #79

merged 6 commits into from
Mar 6, 2024

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Feb 28, 2024

Added

  • Added Black actions
  • Add pre-commit, black,isort and ruff

Changed

  • Update actions versions

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim requested a review from a team as a code owner February 28, 2024 16:29
@henrikstranneheim henrikstranneheim self-assigned this Feb 28, 2024
@henrikstranneheim henrikstranneheim added Bug Something isn't working Enhancement New feature or request labels Feb 28, 2024
@henrikstranneheim henrikstranneheim removed the Bug Something isn't working label Mar 1, 2024
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

# Conflicts:
#	requirements.txt
@henrikstranneheim
Copy link
Contributor Author

API 👍

iseq.clinical@cg-services-stage ~]$ systemctl --user status genotype-api@add-black
● [email protected] - Genotype-api
   Loaded: loaded (/home/hiseq.clinical/.config/systemd/user/[email protected]; disabled; vendor preset: enabled)
   Active: active (running) since Wed 2024-03-06 09:42:31 CET; 49s ago
  Process: 3534793 ExecStartPre=/usr/bin/podman pull ${CONTAINER_URL}:add-black (code=exited, status=0/SUCCESS)
 Main PID: 3534875 (podman)
   CGroup: /user.slice/user-2191.slice/[email protected]/genotype\x2dapi.slice/[email protected]
           ├─3534875 /usr/bin/podman run --expose 25000 --security-opt label=disable --env-file /var/cg-data/container-env//genotype-api.env --replace --init --tz local --name genotype-api-add-black -p 7>
           ├─3534890 /usr/bin/fuse-overlayfs -o lowerdir=/home/hiseq.clinical/.local/share/containers/storage/overlay/l/42FTNKXGRATXNO5YEUEHS3D6ZH:/home/hiseq.clinical/.local/share/containers/storage/ove>
           ├─3534892 /usr/bin/slirp4netns --disable-host-loopback --mtu=65520 --enable-sandbox --enable-seccomp --enable-ipv6 -c -r 3 -e 4 --netns-type=path /run/user/2191/netns/netns-13f26804-e0fc-1f80->
           ├─3534895 rootlessport
           ├─3534901 rootlessport-child
           ├─3534910 /usr/bin/conmon --api-version 1 -c 0c8c8799e8ab5ecaec91cee3551f8a2fd9cc6dacc14daa08ca409e78ff790dc1 -u 0c8c8799e8ab5ecaec91cee3551f8a2fd9cc6dacc14daa08ca409e78ff790dc1 -r /usr/bin/ru>
           └─0c8c8799e8ab5ecaec91cee3551f8a2fd9cc6dacc14daa08ca409e78ff790dc1
             ├─3534921 /run/podman-init -- /bin/sh -c gunicorn     --workers=$GUNICORN_WORKERS     --bind=$GUNICORN_BIND      --threads=$GUNICORN_THREADS     --timeout=$GUNICORN_TIMEOUT     --proxy-proto>
             ├─3534933 /bin/sh -c gunicorn     --workers=$GUNICORN_WORKERS     --bind=$GUNICORN_BIND      --threads=$GUNICORN_THREADS     --timeout=$GUNICORN_TIMEOUT     --proxy-protocol     --forwarded->
             ├─3534934 /usr/local/bin/python /usr/local/bin/gunicorn --workers=4 --bind=0.0.0.0:8000 --threads=4 --timeout=400 --proxy-protocol --forwarded-allow-ips=10.0.2.100,127.0.0.1 --log-syslog --a>
             ├─3534935 /usr/local/bin/python /usr/local/bin/gunicorn --workers=4 --bind=0.0.0.0:8000 --threads=4 --timeout=400 --proxy-protocol --forwarded-allow-ips=10.0.2.100,127.0.0.1 --log-syslog --a>
             ├─3534936 /usr/local/bin/python /usr/local/bin/gunicorn --workers=4 --bind=0.0.0.0:8000 --threads=4 --timeout=400 --proxy-protocol --forwarded-allow-ips=10.0.2.100,127.0.0.1 --log-syslog --a>
             ├─3534937 /usr/local/bin/python /usr/local/bin/gunicorn --workers=4 --bind=0.0.0.0:8000 --threads=4 --timeout=400 --proxy-protocol --forwarded-allow-ips=10.0.2.100,127.0.0.1 --log-syslog --a>
             └─3534938 /usr/local/bin/python /usr/local/bin/gunicorn --workers=4 --bind=0.0.0.0:8000 --threads=4 --timeout=400 --proxy-protocol --forwarded-allow-ips=10.0.2.100,127.0.0.1 --log-syslog --a>

Mar 06 09:42:33 cg-services-stage.scilifelab.se podman[3534875]: [2024-03-06 09:42:33 +0100] [11] [INFO] Waiting for application startup.
Mar 06 09:42:33 cg-services-stage.scilifelab.se podman[3534875]: [2024-03-06 09:42:33 +0100] [12] [INFO] Waiting for application startup.
Mar 06 09:42:33 cg-services-stage.scilifelab.se podman[3534875]: [2024-03-06 09:42:33 +0100] [11] [INFO] Application startup complete.
Mar 06 09:42:33 cg-services-stage.scilifelab.se podman[3534875]: [2024-03-06 09:42:33 +0100] [12] [INFO] Application startup complete.
Mar 06 09:42:33 cg-services-stage.scilifelab.se podman[3534875]: [2024-03-06 09:42:33 +0100] [10] [INFO] Application startup complete.
Mar 06 09:42:33 cg-services-stage.scilifelab.se podman[3534875]: [2024-03-06 09:42:33 +0100] [9] [INFO] Application startup complete.
Mar 06 09:43:06 cg-services-stage.scilifelab.se podman[3534875]: 130.237.250.5:0 - "OPTIONS /samples/?skip=0&limit=100&incomplete=false& HTTP/1.0" 200
Mar 06 09:43:07 cg-services-stage.scilifelab.se podman[3534875]: 130.237.250.5:0 - "GET /samples/?skip=0&limit=100&incomplete=false& HTTP/1.0" 200
Mar 06 09:43:11 cg-services-stage.scilifelab.se podman[3534875]: 130.237.250.5:0 - "OPTIONS /users/ HTTP/1.0" 200
Mar 06 09:43:11 cg-services-stage.scilifelab.se podman[3534875]: 130.237.250.5:0 - "GET /users/ HTTP/1.0" 200

@henrikstranneheim henrikstranneheim merged commit 686cef8 into main Mar 6, 2024
4 checks passed
@henrikstranneheim henrikstranneheim deleted the add-black branch March 6, 2024 08:46
@henrikstranneheim
Copy link
Contributor Author

Nothing to deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants