Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(update): idna #145

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat(update): idna #145

merged 1 commit into from
Jun 4, 2024

Conversation

henrikstranneheim
Copy link
Contributor

Added

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim self-assigned this Jun 3, 2024
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner June 3, 2024 07:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@henrikstranneheim
Copy link
Contributor Author

API 👍

Screenshot 2024-06-03 at 09 23 05

islean
islean approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@henrikstranneheim henrikstranneheim merged commit 406a567 into main Jun 4, 2024
5 checks passed
@henrikstranneheim henrikstranneheim deleted the update-idna branch June 4, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees

@henrikstranneheim henrikstranneheim

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikstranneheim @islean