Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plate upload) #137

Merged
merged 15 commits into from
Apr 12, 2024
Merged

fix(plate upload) #137

merged 15 commits into from
Apr 12, 2024

Conversation

ChrOertlin
Copy link
Contributor

Added

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner April 11, 2024 12:34
islean
islean approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is more of a visual update? So that the user can see that the plate already exists?

genotype_api/services/endpoint_services/plate_service.py Show resolved Hide resolved
seallard
seallard approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin
Copy link
Contributor Author

Upload works:

image

@ChrOertlin ChrOertlin merged commit ef3db16 into main Apr 12, 2024
5 checks passed
@ChrOertlin ChrOertlin deleted the fix-plate-upload branch April 12, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seallard seallard seallard approved these changes

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @seallard @islean