Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(storehelpers and tests) #127

Merged
merged 7 commits into from
Apr 8, 2024
Merged

add(storehelpers and tests) #127

merged 7 commits into from
Apr 8, 2024

Conversation

ChrOertlin
Copy link
Contributor

Added

Adds the store helpers and fixtures to setup store tests

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner April 8, 2024 09:34
@Karl-Svard Karl-Svard requested a review from Vince-janv April 8, 2024 11:43
@ChrOertlin ChrOertlin mentioned this pull request Apr 8, 2024
Merged
6 tasks
Vince-janv
Vince-janv approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the test-suite fleshed out 👍 I do think the functional changes (if you which to make them) should be in a separate PR though

genotype_api/database/crud/read.py Show resolved Hide resolved
genotype_api/database/crud/read.py Show resolved Hide resolved
tests/store_helpers.py Outdated Show resolved Hide resolved
tests/store_helpers.py Outdated Show resolved Hide resolved
tests/store_helpers.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit bccd87d into main Apr 8, 2024
3 checks passed
@ChrOertlin ChrOertlin deleted the setup-test-store branch April 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vince-janv Vince-janv Vince-janv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @Vince-janv