Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(plate service) #111

Merged
merged 33 commits into from
Mar 25, 2024
Merged

add(plate service) #111

merged 33 commits into from
Mar 25, 2024

Conversation

ChrOertlin
Copy link
Contributor

Added

Adds a plate service to translate database models to dtos

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner March 22, 2024 12:47
@ChrOertlin ChrOertlin marked this pull request as draft March 22, 2024 13:20
@ChrOertlin ChrOertlin marked this pull request as ready for review March 22, 2024 13:26
@ChrOertlin ChrOertlin marked this pull request as draft March 25, 2024 09:36
@ChrOertlin
Copy link
Contributor Author

plates can be fetched and signed off on stage

@ChrOertlin ChrOertlin marked this pull request as ready for review March 25, 2024 12:27
henrikstranneheim
henrikstranneheim approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Cleaner and cleaner, 👍 .

genotype_api/api/endpoints/plates.py Show resolved Hide resolved
genotype_api/api/endpoints/plates.py Show resolved Hide resolved
genotype_api/database/crud/read.py Outdated Show resolved Hide resolved
genotype_api/dto/plate.py Outdated Show resolved Hide resolved
genotype_api/dto/user.py Outdated Show resolved Hide resolved
tests/crud/read/test_read_plate.py Outdated Show resolved Hide resolved
ChrOertlin and others added 2 commits March 25, 2024 16:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit 4fbdea7 into main Mar 25, 2024
3 checks passed
@ChrOertlin ChrOertlin deleted the add-plate-service branch March 25, 2024 15:33
ChrOertlin added a commit that referenced this pull request Mar 25, 2024
@ChrOertlin
Revert "add(plate service) (#111) (patch)"
5089d47 
This reverts commit 4fbdea7.
@ChrOertlin ChrOertlin mentioned this pull request Mar 25, 2024
Closed
@ChrOertlin ChrOertlin restored the add-plate-service branch March 25, 2024 15:35
@ChrOertlin ChrOertlin deleted the add-plate-service branch March 25, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikstranneheim henrikstranneheim henrikstranneheim approved these changes

@diitaz93 diitaz93 Awaiting requested review from diitaz93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @henrikstranneheim