-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(pydantic) #104
update(pydantic) #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, 👍
@@ -1,18 +1,19 @@ | |||
SQLAlchemy==1.4.30 | |||
SQLAlchemy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a subtlety (or at least I am quite certain there is) in that optionals have changed behaviour. Previously a: str | None
would mean that you could instantiate the BaseModel without a
set. That is not the case in Pydantic v2. The same behaviour would be achieved by a: str | None = None
. Please double check if I am correct though.
edit: I was mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, thought SQLModels extended BaseModels! Looks good!
Quality Gate failedFailed conditions |
This proves to be more of a hassle than I thought |
Closing, done in another PR |
Added
Update to pydantic v2
Changed
Fixed
Steps to consider while deploying
Review:
This version is a: