Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pep_0585): #102

Merged
merged 2 commits into from
Mar 13, 2024
Merged

feat(pep_0585): #102

merged 2 commits into from
Mar 13, 2024

Conversation

henrikstranneheim
Copy link
Contributor

@henrikstranneheim henrikstranneheim commented Mar 12, 2024 •
edited
Loading

Added

Changed

  • Refactor to PEP 0585

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@henrikstranneheim henrikstranneheim self-assigned this Mar 12, 2024
@henrikstranneheim henrikstranneheim requested a review from a team as a code owner March 12, 2024 14:46
@henrikstranneheim henrikstranneheim linked an issue Mar 12, 2024 that may be closed by this pull request
Refactor to pep 0585 #85
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.7% Duplication on New Code

See analysis details on SonarCloud

islean
islean approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrikstranneheim
Copy link
Contributor Author

Container 👍

@henrikstranneheim henrikstranneheim merged commit 66133b7 into main Mar 13, 2024
3 checks passed
@henrikstranneheim henrikstranneheim deleted the pep-0585 branch March 13, 2024 14:59
@henrikstranneheim
Copy link
Contributor Author

Deployed in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees

@henrikstranneheim henrikstranneheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor to pep 0585
2 participants
@henrikstranneheim @islean