-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1781 - Update 'Save' button behavior on view-only pages (Case-… #1960
base: dev
Are you sure you want to change the base?
Conversation
…Control, Proband Individual, and Experimental Data).
Steps to test #1781 in different evidences: To test "Save" button is disabled when nothing can be changed.
To test warning message if no change is made when "Save" button is clicked.
To test same behavior for Proland Individual evidence;
To test same behavior for Experimental Data:
|
Just wanted to clarify for others testing this, although maybe I am missing something. I was successfully able to view the disabled Score input and Save button by completing all of the required fields and NOT selecting a study type. Looks great from there :) |
this.state.modifiedScore === 'none' && this.state.origScore === null) && | ||
(this.state.scoreExplanation === this.state.origScoreExplanation || | ||
this.state.scoreExplanation === '' && this.state.origScoreExplanation === null)) { | ||
this.setState({scoreError: true, scoreErrorMsg: 'Cannot save because no field has been modified. Please make your changes then save.'}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about changing the scoreErrorMsg
to 'Cannot save because the score/explanation has not been modified..'
Just a small suggestion for clarity!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No errors or issues when testing the UI. Let me know what you think about the error text!
…Control, Proband Individual, and Experimental Data).