Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1512 - Fixed the problem that if score is changed to 0, the ch… #1958

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

gcheung-SF
Copy link
Contributor

…anged score is missing from Case-control, Experimental Data and Individual evidences.

…anged score is missing from Case-control, Experimental Data and Individual evidences.
@gcheung-SF
Copy link
Contributor Author

Steps to test #1512:

  1. Log in as yourself.
  2. Create a new Gene-Disease Record.
  3. Add an article by PMIDs.
  4. Create a case-control evidence and score with a number.
  5. Change affiliation and associate yourself with an affiliation.
  6. Select the same Gene-Disease record that's created in Log in system #2.
  7. Click View/score link in case-control evidence that's created in Gene Disease Input #4.
  8. Select 0 for the score.
  9. Change affiliation and back as yourself.
  10. View/Score the same case-control evidence. See the 0 scored entry is displayed under "Case-Control - Other Curator Scores" section.

Repeat the same testing with Individual evidence.

  1. Log in as yourself.
  2. Create a new Gene-Disease Record.
  3. Add an article by PMIDs.
  4. Create an Individual evidence, select "Yes" for "Is this Individual a proband" field, select an variant, select "score" in "Select Status" field, and use default score or score with a number.
  5. Change affiliation and associate yourself with an affiliation.
  6. Select the same Gene-Disease record that's created in Log in system #2.
  7. Click the View/Score link in individual evidence created in Gene Disease Input #4.
  8. Scroll down to "Individual - Score Proband" section, select 0 for "Select a score different from default score" field, enter text in "Explanation" field and click "Save" button.
  9. Change affiliation and back as yourself.
  10. View/Score the same individual evidence. See the 0 scored entry is displayed under "Individual - Other Curator Scores" section.

Repeat the same testing with Experimental Data evidences.

  1. Log in as yourself.
  2. Create a new Gene-Disease Record.
  3. Add an article by PMIDs.
  4. Create an Experimental evidence, select any value for required fields, select "score" for "Select Status" field and score a number.
  5. Change affiliation and associate yourself with an affiliation.
  6. Select the same Gene-Disease record that's created in Log in system #2.
  7. Click the View/Score link in experimental evidence created in Gene Disease Input #4.
  8. Scroll down to "Experimental Data Score" section, select 0 for "Select a score different from default score" field, enter text in "Explanation" field and click "Save" button.
  9. Change affiliation and back as yourself.
  10. View/Score the same experimental evidence. See the 0 scored entry is displayed under "Case-Control - Other Curator Scores" section.

@h-tong h-tong self-requested a review November 8, 2019 22:50
Copy link
Contributor

@h-tong h-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are tests that fail when I run them locally, but I think it is because the branch hasn't been updated with dev in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants