-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connects to #1824, #2011: Adds confirm modal for no criteria summary #1941
base: dev
Are you sure you want to change the base?
Conversation
src/clincoded/static/components/variant_central/interpretation/summary.js
Outdated
Show resolved
Hide resolved
src/clincoded/static/components/variant_central/interpretation/summary.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Matt, the absence of criteria in the Not yet evaluated table/panel of the standalone summary (e.g. the new tab/window that appears when clicking on the View Provisional Summary button) needs to be corrected before this can go live. This change, plus some others (for both interpretation summary views), is described in #2011. If you're amenable, I'd like to assign #2011 to you and have it be incorporated into this branch/PR.
Steps to test #1824
Steps to test #2011