Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #1824, #2011: Adds confirm modal for no criteria summary #1941

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

h-tong
Copy link
Contributor

@h-tong h-tong commented Jun 7, 2019

Steps to test #1824

  1. Click New Variant Curation and enter a ClinVar ID in the variant lookup modal.
  2. Proceed to the "Evidence View" and click the Interpretation button to add an interpretation
  3. Click View Summary on the right side of the variant interpretation header
  4. Expect a modal to pop up with the option to proceed or to cancel.
  5. Click Continue and you should see the "Evidence Summary" with no criteria evaluated
  6. Click the Save button and expect for the save to be successful

Steps to test #2011

  1. Expect "Criteria meeting an evaluation strength" panel to have text "No criteria meeting an evaluation strength."
  2. Expect "Criteria evaluated as 'Not met'" panel to have text "No criteria evaluated as 'Not met'".
  3. Expect "Criteria 'Not yet evaluated'" panel to include a table with the criteria that has not yet been evaluated.
  4. In the "Save Interpretation as Provisional" panel, click Preview Provisional and then Submit Provisional
  5. Click View Provisional Summary and repeat the checks in steps 7 - 9 (the three mentioned panels should be identical to the Evidence Summary from the previous page

@bryanwulf bryanwulf self-requested a review August 16, 2019 21:17
Copy link
Contributor

@bryanwulf bryanwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Matt, the absence of criteria in the Not yet evaluated table/panel of the standalone summary (e.g. the new tab/window that appears when clicking on the View Provisional Summary button) needs to be corrected before this can go live. This change, plus some others (for both interpretation summary views), is described in #2011. If you're amenable, I'd like to assign #2011 to you and have it be incorporated into this branch/PR.

@h-tong h-tong changed the title Connects to #1824: Adds confirm modal for no criteria summary Connects to #1824, #2011: Adds confirm modal for no criteria summary Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants