Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #1906: Disabled UI for criteria #1939

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

h-tong
Copy link
Contributor

@h-tong h-tong commented Jun 5, 2019

No description provided.

@h-tong h-tong changed the title Connects to #1906. Disabled UI for criteria Connects to #1906: Disabled UI for criteria Jun 5, 2019
@bryanwulf
Copy link
Contributor

@h-tong Items to discuss/address...
In multiple files:

  • check/ensure that variables (like this.props.unusedCriteria) are defined before accessing "child" properties/methods (like indexOf())

In src/clincoded/static/components/variant_central/index.js:

  • add unusedCriteria to state (vs. setting the default with a const)

In src/clincoded/static/components/variant_central/interpretation/segregation.js:

  • update comments for criteriaGroup8 function (to match modified argument name)

In src/clincoded/static/components/variant_central/interpretation/shared/form.js:

  • avoid reuse of disableEvalForm (argument and variable name) in renderEvalFormSection()
  • avoid use of this.props in renderEvalFormSection() (not part of a component)

@bryanwulf bryanwulf self-requested a review August 9, 2019 23:00
* Disabling form currently only applies to 'BP6' and 'PP5' if the gene is NEITHER BRCA1 or BRCA2
* @param {boolean} disableEvalForm - The flag to disable criteria evaluation form
* Disabling form currently only applies to 'BP6' and 'PP5'
* @param {boolean} unusedCriteria - An array of criteria that are not active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param {boolean} unusedCriteria - An array of criteria that are not active
* @param {array} unusedCriteria - An array of criteria that are not active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants