Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rustls #102

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Support rustls #102

merged 9 commits into from
Jul 16, 2024

Conversation

cole-h
Copy link
Contributor

@cole-h cole-h commented Feb 6, 2024

Closes #97.

@cole-h cole-h mentioned this pull request Feb 6, 2024
Closed
@cole-h cole-h mentioned this pull request Jun 4, 2024
Closed
frectonz added a commit to frectonz/clickhouse.rs that referenced this pull request Jul 8, 2024
@frectonz
rustls from ClickHouse#102
e33e443
@loyd
Copy link
Collaborator

loyd commented Jul 15, 2024

@cole-h, would you like to rebase the branch (the master now is based on hyper-v1)?

loyd
loyd reviewed Jul 15, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@loyd loyd mentioned this pull request Jul 15, 2024
Closed
loyd
loyd reviewed Jul 15, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
loyd
loyd reviewed Jul 15, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
loyd
loyd reviewed Jul 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@loyd loyd mentioned this pull request Jul 15, 2024
Open
@cole-h
Copy link
Contributor Author

cole-h commented Jul 15, 2024

I'll take a stab at rebasing and addressing your concerns later today (hopefully) or tomorrow (at the latest)! Thank you!

(If you don't want to wait that long, I do have "allow edits by maintainers" checked, so feel free to push to my branch as well)

@cole-h
Copy link
Contributor Author

cole-h commented Jul 15, 2024

OK, this PR is now up-to-date with master and I believe incorporates all the changes you suggested.

loyd
loyd reviewed Jul 16, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
loyd
loyd reviewed Jul 16, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
loyd
loyd reviewed Jul 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@loyd
Copy link
Collaborator

loyd commented Jul 16, 2024

Ok, it is ready to merge. I'll update CI to check compilation (sadly not tests yet) and the changelog and publish a new library version.

Thanks for your contribution!

@loyd loyd merged commit e93e4be into ClickHouse:master Jul 16, 2024
6 checks passed
@cole-h cole-h deleted the rustls branch July 16, 2024 15:43
@cole-h cole-h restored the rustls branch July 16, 2024 15:43
@cole-h
Copy link
Contributor Author

cole-h commented Jul 16, 2024

Thank you for your support, and for this crate!

@cole-h cole-h deleted the rustls branch July 16, 2024 15:49
loyd added a commit that referenced this pull request Jul 16, 2024
@loyd
docs(CHANGELOG): note about #102
c51b6ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loyd loyd loyd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cole-h @loyd @tyrchen