-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check the X-ClickHouse-Exception-Code for err code #350
base: main
Are you sure you want to change the base?
Conversation
It does not fix it for select streaming, as the headers will already be received; this is only for inserts. |
ok, so this solves a similar issue we had, should i open a separate issue for that? |
No, this is fine. Thanks for the contribution! |
@dermasmid, is it possible to add an integration test for that? And one more question: in case of a CH error rejection, we usually return an instance of |
in theory the error should be parsed just fine, since it's using regex to find the error from the body:
ill try to get a test in too |
Summary
use the
X-ClickHouse-Exception-Code
header ClickHouse/ClickHouse#8786Related: #332 (similar issue can happen with inserts)