Generic client, Browser + Node.js connections

.build/update_version.ts

@@ -1,4 +1,4 @@
-import version from '../src/version'
+import version from '../packages/client-common/src/version'
 import packageJson from '../package.json'
 import fs from 'fs'
 ;(async () => {

.docker/clickhouse/single_node_tls/Dockerfile

@@ -1,4 +1,4 @@
-FROM clickhouse/clickhouse-server:23.2-alpine
+FROM clickhouse/clickhouse-server:23.4-alpine
 COPY .docker/clickhouse/single_node_tls/certificates /etc/clickhouse-server/certs
 RUN chown clickhouse:clickhouse -R /etc/clickhouse-server/certs \
     && chmod 600 /etc/clickhouse-server/certs/* \

.eslintignore

@@ -0,0 +1,3 @@
+dist
+node_modules
+webpack

.eslintrc.json

@@ -28,7 +28,9 @@
       "files": ["./__tests__/**/*.ts"],
       "rules": {
         "@typescript-eslint/no-explicit-any": "off",
-        "@typescript-eslint/no-non-null-assertion": "off"
+        "@typescript-eslint/no-non-null-assertion": "off",
+        "@typescript-eslint/ban-ts-comment": "off",
+        "no-constant-condition": "off"
       }
     }
   ]

.github/workflows/tests.yml

@@ -2,15 +2,6 @@ name: 'tests'
 
 on:
   workflow_dispatch:
-    inputs:
-      push-coverage-report:
-        type: choice
-        required: true
-        description: Push coverage
-        options:
-          - yes
-          - no
-        default: no
   push:
     branches:
       - main
@@ -23,7 +14,7 @@ on:
     branches:
       - main
     paths-ignore:
-      - 'README.md'
+      - '**/*.md'
       - 'LICENSE'
       - 'benchmarks/**'
       - 'examples/**'
@@ -32,7 +23,7 @@ on:
     - cron: '0 9 * * *'
 
 jobs:
-  build:
+  node-unit-tests:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
@@ -62,8 +53,39 @@ jobs:
         run: |
           npm run test:unit
 
-  integration-tests-local-single-node:
-    needs: build
+  browser-all-tests-local-single-node:
+    runs-on: ubuntu-latest
+    needs: node-unit-tests
+    strategy:
+      fail-fast: true
+      matrix:
+        clickhouse: [ head, latest ]
+    steps:
+      - uses: actions/checkout@main
+
+      - name: Start ClickHouse (version - ${{ matrix.clickhouse }}) in Docker
+        uses: isbang/[email protected]
+        env:
+          CLICKHOUSE_VERSION: ${{ matrix.clickhouse }}
+        with:
+          compose-file: 'docker-compose.yml'
+          down-flags: '--volumes'
+
+      - name: Setup NodeJS
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
+      - name: Install dependencies
+        run: |
+          npm install
+
+      - name: Run all browser tests
+        run: |
+          npm run test:browser
+
+  node-integration-tests-local-single-node:
+    needs: node-unit-tests
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
@@ -97,22 +119,12 @@ jobs:
 
       # Includes TLS integration tests run
       # Will also run unit tests, but that's almost free.
-      # Otherwise, we need to set up a separate job,
-      # which will also run the integration tests for the second time,
-      # and that's more time-consuming.
       - name: Run all tests
         run: |
-          npm t -- --coverage
-
-      - name: Upload coverage report
-        uses: actions/upload-artifact@v3
-        with:
-          name: coverage
-          path: coverage
-          retention-days: 1
+          npm t
 
-  integration-tests-local-cluster:
-    needs: build
+  node-integration-tests-local-cluster:
+    needs: node-unit-tests
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
@@ -123,7 +135,7 @@ jobs:
     steps:
       - uses: actions/checkout@main
 
-      - name: Start ClickHouse (version - ${{ matrix.clickhouse }}) in Docker
+      - name: Start ClickHouse cluster (version - ${{ matrix.clickhouse }}) in Docker
         uses: isbang/[email protected]
         env:
           CLICKHOUSE_VERSION: ${{ matrix.clickhouse }}
@@ -144,8 +156,39 @@ jobs:
         run: |
           npm run test:integration:local_cluster
 
-  integration-tests-cloud:
-    needs: build
+  browser-integration-tests-local-cluster:
+    runs-on: ubuntu-latest
+    needs: node-unit-tests
+    strategy:
+      fail-fast: true
+      matrix:
+        clickhouse: [ head, latest ]
+    steps:
+      - uses: actions/checkout@main
+
+      - name: Start ClickHouse cluster (version - ${{ matrix.clickhouse }}) in Docker
+        uses: isbang/[email protected]
+        env:
+          CLICKHOUSE_VERSION: ${{ matrix.clickhouse }}
+        with:
+          compose-file: 'docker-compose.cluster.yml'
+          down-flags: '--volumes'
+
+      - name: Setup NodeJS
+        uses: actions/setup-node@v3
+        with:
+          node-version: 16
+
+      - name: Install dependencies
+        run: |
+          npm install
+
+      - name: Run all browser tests
+        run: |
+          npm run test:browser:integration:local_cluster
+
+  node-integration-tests-cloud:
+    needs: node-unit-tests
     runs-on: ubuntu-latest
     strategy:
       fail-fast: true
@@ -171,34 +214,24 @@ jobs:
         run: |
           npm run test:integration:cloud
 
-  upload-coverage-and-badge:
-    if: github.ref == 'refs/heads/main' && github.event.inputs.push-coverage-report != 'no'
-    needs:
-      - integration-tests-local-single-node
-      - integration-tests-local-cluster
-      - integration-tests-cloud
+  browser-integration-tests-cloud:
+    needs: node-unit-tests
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-        with:
-          repository: ${{ github.event.pull_request.head.repo.full_name }}
-          ref: ${{ github.event.pull_request.head.ref }}
+      - uses: actions/checkout@main
+
       - name: Setup NodeJS
         uses: actions/setup-node@v3
         with:
           node-version: 16
-      - name: Download coverage report
-        uses: actions/download-artifact@v3
-        with:
-          name: coverage
-          path: coverage
-      - name: Install packages
-        run: npm i -G make-coverage-badge
-      - name: Generate badge
-        run: npx make-coverage-badge
-      - name: Make "Coverage" lowercase for style points
-        run: sed -i 's/Coverage/coverage/g' coverage/badge.svg
-      - uses: stefanzweifel/git-auto-commit-action@v4
-        with:
-          file_pattern: 'coverage'
-          commit_message: '[skip ci] Update coverage report'
+
+      - name: Install dependencies
+        run: |
+          npm install
+
+      - name: Run integration tests
+        env:
+          CLICKHOUSE_CLOUD_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST }}
+          CLICKHOUSE_CLOUD_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD }}
+        run: |
+          npm run test:browser:integration:cloud

.gitignore

@@ -5,3 +5,4 @@ node_modules
 benchmarks/leaks/input
 *.tgz
 .npmrc
+webpack

README.md

@@ -6,10 +6,6 @@
 <p align="center">
 <a href="https://github.com/ClickHouse/clickhouse-js/actions/workflows/tests.yml">
 <img src="https://github.com/ClickHouse/clickhouse-js/actions/workflows/tests.yml/badge.svg?branch=main">
-</a>
-<a href="http://htmlpreview.github.io/?https://github.com/ClickHouse/clickhouse-js/blob/main/coverage/lcov-report/index.html">
-<img src="./coverage/badge.svg">
-</a>
 </p>
 
 ## About