Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parquet and file streaming docs for CHJS #1621

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Add Parquet and file streaming docs for CHJS #1621

merged 2 commits into from
Oct 31, 2023

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Oct 30, 2023

  • Updated client <-> ClickHouse versions
  • Rearranged "web limitations"
  • Add file streaming examples links
  • Add Parquet to the support formats table

NB: I think that table is currently missing the "Output (Stream)" column, which will be added as a follow-up, as Parquet as text probably does not make much sense.

See also: ClickHouse/clickhouse-js#208

@slvrtrn slvrtrn requested a review from a team as a code owner October 30, 2023 21:03
@slvrtrn slvrtrn requested review from mshustov and removed request for a team October 30, 2023 21:03
@robot-ch-test-poll1
Copy link

robot-ch-test-poll1 commented Oct 30, 2023

This is an automated comment for commit ac72777 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Docs CheckBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
VercelThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success

Copy link
Contributor

@johnnymatthews johnnymatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm not a huge fan of line character limits, but we don't have to update every page right now.

@mshustov mshustov merged commit 1a075e5 into main Oct 31, 2023
7 checks passed
@mshustov mshustov deleted the chjs-parquet branch October 31, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants