Fill additional CenterField halos on cubed sphere panels for correct SSH interpolation #4748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthabishnu
added a commit
that referenced
this pull request
Aug 31, 2025
siddharthabishnu
force-pushed
the
sb/cs-center-halo
branch
from
4ac0156 to
6a0f640
Compare
siddharthabishnu
added a commit
that referenced
this pull request
Sep 1, 2025
siddharthabishnu
added a commit
that referenced
this pull request
Sep 1, 2025
siddharthabishnu
force-pushed
the
sb/cs-center-halo
branch
from
0bac49d to
01fde02
Compare
siddharthabishnu
added a commit
that referenced
this pull request
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills additional halo regions of
CenterFieldon cubed sphere panels. Previously, when interpolating sea surface height (SSH), η, from cell centers to edge locations (Center-Face and Face-Center), uninitialized corner halo values of η produced incorrect interpolated values at the edges. This, in turn, affected the computed column depths at those edge locations.With this update, the missing η halos are filled, ensuring that interpolation to edge locations produces consistent results. This eliminates the spurious values that could previously lead to inaccuracies and potential instabilities.
Finally, this PR enlarges the extended halo region to include the extra layer needed for
CenterFieldto correctly interpolate to the outermost southern and western edges of cubed sphere panels.