Remove tendency computation at model construction

src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl

@@ -25,10 +25,10 @@ Update peripheral aspects of the model (auxiliary fields, halo regions, diffusiv
 hydrostatic pressure) to the current model state. If `callbacks` are provided (in an array),
 they are called in the end.
 """
-update_state!(model::HydrostaticFreeSurfaceModel, callbacks=[]; compute_tendencies = true) =
+update_state!(model::HydrostaticFreeSurfaceModel, callbacks=[]; compute_tendencies = false) =
     update_state!(model, model.grid, callbacks; compute_tendencies)
 
-function update_state!(model::HydrostaticFreeSurfaceModel, grid, callbacks; compute_tendencies = true)
+function update_state!(model::HydrostaticFreeSurfaceModel, grid, callbacks; compute_tendencies = false)
     @apply_regionally mask_immersed_model_fields!(model, grid)
 
     # Update possible FieldTimeSeries used in the model

src/Models/NonhydrostaticModels/nonhydrostatic_model.jl

@@ -231,7 +231,7 @@ function NonhydrostaticModel(; grid,
                                 auxiliary_fields)
 
     update_state!(model)
-
+    
     return model
 end
 

src/Models/NonhydrostaticModels/update_nonhydrostatic_model_state.jl

@@ -17,7 +17,7 @@ Update peripheral aspects of the model (halo regions, diffusivities, hydrostatic
 pressure) to the current model state. If `callbacks` are provided (in an array),
 they are called in the end.
 """
-function update_state!(model::NonhydrostaticModel, callbacks=[]; compute_tendencies = true)
+function update_state!(model::NonhydrostaticModel, callbacks=[]; compute_tendencies = false)
 
     # Mask immersed tracers
     foreach(model.tracers) do tracer

src/Models/ShallowWaterModels/update_shallow_water_state.jl

@@ -18,7 +18,7 @@ Next, `callbacks` are executed.
 
 Finally, tendencies are computed if `compute_tendencies=true`.
 """
-function update_state!(model::ShallowWaterModel, callbacks=[]; compute_tendencies=true)
+function update_state!(model::ShallowWaterModel, callbacks=[]; compute_tendencies=false)
 
     # Mask immersed fields
     foreach(mask_immersed_field!, merge(model.solution, model.tracers))

src/TimeSteppers/quasi_adams_bashforth_2.jl

@@ -57,7 +57,7 @@ reset!(timestepper::QuasiAdamsBashforth2TimeStepper) = nothing
 #####
 
 """
-    time_step!(model::AbstractModel{<:QuasiAdamsBashforth2TimeStepper}, Δt; euler=false, compute_tendencies=true)
+    time_step!(model::AbstractModel{<:QuasiAdamsBashforth2TimeStepper}, Δt; euler=false)
 
 Step forward `model` one time step `Δt` with a 2nd-order Adams-Bashforth method and
 pressure-correction substep. Setting `euler=true` will take a forward Euler time step.
@@ -71,11 +71,7 @@ The steps of the Quasi-Adams-Bashforth second-order (AB2) algorithm are:
 4. Correct the velocities based on the results of step 3.
 5. Store the old tendencies.
 6. Update the model state.
-7. If `compute_tendencies == true`, compute the tendencies for the next time step.
-
-!!! warning "`compute_tendencies` kwarg"
-    If `compute_tendencies == false` then the new tendencies at the last step are _not_ calculated!
-    Setting `compute_tendencies == false` is not recommended _except_ for debugging purposes.
+7. Compute tendencies for the next time step
 """
 function time_step!(model::AbstractModel{<:QuasiAdamsBashforth2TimeStepper}, Δt;
                     callbacks=[], euler=false, compute_tendencies=true)
@@ -113,7 +109,7 @@ function time_step!(model::AbstractModel{<:QuasiAdamsBashforth2TimeStepper}, Δt
     end
 
     # Be paranoid and update state at iteration 0
-    model.clock.iteration == 0 && update_state!(model, callbacks)
+    model.clock.iteration == 0 && update_state!(model, callbacks; compute_tendencies=true)
 
     ab2_step!(model, Δt) # full step for tracers, fractional step for velocities.
 
@@ -124,7 +120,7 @@ function time_step!(model::AbstractModel{<:QuasiAdamsBashforth2TimeStepper}, Δt
     calculate_pressure_correction!(model, Δt)
     @apply_regionally correct_velocities_and_store_tendencies!(model, Δt)
 
-    update_state!(model, callbacks; compute_tendencies)
+    update_state!(model, callbacks; compute_tendencies=true)
     step_lagrangian_particles!(model, Δt)
 
     # Return χ to initial value

src/TimeSteppers/runge_kutta_3.jl

@@ -78,11 +78,11 @@ The 3rd-order Runge-Kutta method takes three intermediate substep stages to
 achieve a single timestep. A pressure correction step is applied at each intermediate
 stage.
 """
-function time_step!(model::AbstractModel{<:RungeKutta3TimeStepper}, Δt; callbacks=[], compute_tendencies = true)
+function time_step!(model::AbstractModel{<:RungeKutta3TimeStepper}, Δt; callbacks=[])
     Δt == 0 && @warn "Δt == 0 may cause model blowup!"
 
     # Be paranoid and update state at iteration 0, in case run! is not used:
-    model.clock.iteration == 0 && update_state!(model, callbacks)
+    model.clock.iteration == 0 && update_state!(model, callbacks; compute_tendencies = true)
 
     γ¹ = model.timestepper.γ¹
     γ² = model.timestepper.γ²
@@ -111,7 +111,7 @@ function time_step!(model::AbstractModel{<:RungeKutta3TimeStepper}, Δt; callbac
     pressure_correct_velocities!(model, first_stage_Δt)
 
     store_tendencies!(model)
-    update_state!(model, callbacks)
+    update_state!(model, callbacks; compute_tendencies = true)
     step_lagrangian_particles!(model, first_stage_Δt)
 
     #
@@ -127,7 +127,7 @@ function time_step!(model::AbstractModel{<:RungeKutta3TimeStepper}, Δt; callbac
     pressure_correct_velocities!(model, second_stage_Δt)
 
     store_tendencies!(model)
-    update_state!(model, callbacks)
+    update_state!(model, callbacks; compute_tendencies = true)
     step_lagrangian_particles!(model, second_stage_Δt)
 
     #
@@ -148,7 +148,7 @@ function time_step!(model::AbstractModel{<:RungeKutta3TimeStepper}, Δt; callbac
     calculate_pressure_correction!(model, third_stage_Δt)
     pressure_correct_velocities!(model, third_stage_Δt)
 
-    update_state!(model, callbacks; compute_tendencies)
+    update_state!(model, callbacks; compute_tendencies = true)
     step_lagrangian_particles!(model, third_stage_Δt)
 
     return nothing