Fix `_immered_cell` and adapt for `PartialCellBottom` #3682

simone-silvestri · 2024-08-05T20:41:47Z

We can probably use this PR to add also a validation for the PartialCellBottom and the bug-fixes in the implementation.
What do people think?

cc @jm-c

glwagner · 2024-08-05T20:45:05Z

@ali-ramadhan

glwagner · 2024-08-05T20:45:48Z

closes #3681

We can probably use this PR to add also a validation for the PartialCellBottom and the bug-fixes in the implementation. What do people think?

cc @jm-c

presumably we should always use PartialCellBottom in examples with bathymetry. Is there a reason to ever use GridFittedBottom?

glwagner · 2024-08-14T14:18:20Z

How does this PR change adapt?

tomchor · 2024-08-16T20:37:50Z

src/ImmersedBoundaries/partial_cell_bottom.jl

+    # Face node below current cell
+    z  = znode(i, j, k, underlying_grid, c, c, f)
+    h  = @inbounds ib.bottom_height[i, j, 1]
+    ϵ  = ib.minimum_fractional_cell_height
+    # z + Δz is equal to the face above the current cell
+    Δz = Δzᶜᶜᶜ(i, j, k, ibg.underlying_grid)
+    return z + Δz * ϵ ≤ h 


Should we expect this change to fix the weird behaviors we were seeing in #3529 ?

cc @francispoulin

I am not sure, @jm-c is the author of this fix, and he said that with this fix the immersed boundary example did not NaN immediately but it still NaNed after a little bit so we believe there is more bugs to be squashed. You can try that example on this and see if it makes any difference. It will most likely change the solution.

I am happy to try the example from #3529 it on this branch, when you think it's ready for testing.

glwagner · 2024-08-19T15:38:39Z

What are we waiting for to merge this PR?

simone-silvestri · 2024-08-19T17:48:05Z

I guess to have the partial cells working properly, @jm-c was saying there is still some fixes to be done.

glwagner · 2024-08-19T18:44:47Z

The first thing maybe is to add a test that catches the bug.

simone-silvestri · 2024-08-29T14:56:10Z

@ali-ramadhan does this PR fix your issue? I will try the internal tide example on this PR, add some tests for PartialCellBottom, and then we can probably merge it. I am not sure whether this solves all the issues with PartialCellBottom, probably more validation is required, but this is a first step.

simone-silvestri · 2024-08-29T16:19:14Z

This is the status of the internal_tide example on this PR, not producing NaNs anymore, but still not really working.

internal_tide.mp4

ali-ramadhan · 2024-08-29T16:36:16Z

@simone-silvestri I think another error has now come up with the original MWE in issue #3681. I tried the main branch and this branch on two different systems and I'm getting a different CUDA illegal memory access error. Since it's probably not related to this PR I'll open a new issue about it. I'm guessing something is out of bounds in an @inbounds. I'll try catching it with --check-bounds=yes.

MWE:

using Oceananigans
using Oceananigans.ImmersedBoundaries: PartialCellBottom

underlying_grid = RectilinearGrid(GPU(), topology=(Periodic, Flat, Bounded), size=(4, 4), x=(0, 1), z=(0, 1))
slope(x) = x
grid = ImmersedBoundaryGrid(underlying_grid, PartialCellBottom(slope))

model = HydrostaticFreeSurfaceModel(; grid)

Error:

ERROR: CUDA error: an illegal memory access was encountered (code 700, ERROR_ILLEGAL_ADDRESS)
Stacktrace:
  [1] throw_api_error(res::CUDA.cudaError_enum)
    @ CUDA ~/.julia/packages/CUDA/Tl08O/lib/cudadrv/libcuda.jl:30
  [2] check
    @ ~/.julia/packages/CUDA/Tl08O/lib/cudadrv/libcuda.jl:37 [inlined]
  [3] cuStreamGetCaptureInfo
    @ ~/.julia/packages/CUDA/Tl08O/lib/utils/call.jl:34 [inlined]
  [4] capture_status(stream::CUDA.CuStream)
    @ CUDA ~/.julia/packages/CUDA/Tl08O/lib/cudadrv/graph.jl:174
  [5] is_capturing
    @ ~/.julia/packages/CUDA/Tl08O/lib/cudadrv/graph.jl:179 [inlined]
  [6] convert(::Type{CUDA.CuPtr{Float64}}, managed::CUDA.Managed{CUDA.DeviceMemory})
    @ CUDA ~/.julia/packages/CUDA/Tl08O/src/memory.jl:539
  [7] unsafe_convert
    @ ~/.julia/packages/CUDA/Tl08O/src/array.jl:434 [inlined]
  [8] #pointer#1123
    @ ~/.julia/packages/CUDA/Tl08O/src/array.jl:392 [inlined]
  [9] pointer (repeats 2 times)
    @ ~/.julia/packages/CUDA/Tl08O/src/array.jl:384 [inlined]
 [10] unsafe_convert(::Type{CUDA.CuDeviceArray{Float64, 3, 1}}, a::CUDA.CuArray{Float64, 3, CUDA.DeviceMemory})
    @ CUDA ~/.julia/packages/CUDA/Tl08O/src/array.jl:454
 [11] adapt_storage
    @ ~/.julia/packages/CUDA/Tl08O/src/compiler/execution.jl:162 [inlined]
 [12] adapt_structure
    @ ~/.julia/packages/Adapt/7T9au/src/Adapt.jl:57 [inlined]
 [13] adapt
    @ ~/.julia/packages/Adapt/7T9au/src/Adapt.jl:40 [inlined]
 [14] #1
    @ ~/.julia/packages/OffsetArrays/hwmnB/ext/OffsetArraysAdaptExt.jl:9 [inlined]
 [15] parent_call
    @ ~/.julia/packages/OffsetArrays/hwmnB/src/OffsetArrays.jl:315 [inlined]
 [16] adapt_structure
    @ ~/.julia/packages/OffsetArrays/hwmnB/ext/OffsetArraysAdaptExt.jl:9 [inlined]
 [17] adapt
    @ ~/.julia/packages/Adapt/7T9au/src/Adapt.jl:40 [inlined]
 [18] cudaconvert
    @ ~/.julia/packages/CUDA/Tl08O/src/compiler/execution.jl:198 [inlined]
 [19] map
    @ ./tuple.jl:294 [inlined]
 [20] map(f::typeof(CUDA.cudaconvert), t::Tuple{KernelAbstractions.CompilerMetadata{…}, OffsetArrays.OffsetArray{…}, Nothing, Nothing, Tuple{…}, ImmersedBoundaryGrid{…}, Tuple{}})
    @ Base ./tuple.jl:294
 [21] macro expansion
    @ ~/.julia/packages/CUDA/Tl08O/src/compiler/execution.jl:110 [inlined]
 [22] (::KernelAbstractions.Kernel{…})(::OffsetArrays.OffsetArray{…}, ::Vararg{…}; ndrange::Nothing, workgroupsize::Nothing)
    @ CUDA.CUDAKernels ~/.julia/packages/CUDA/Tl08O/src/CUDAKernels.jl:103
 [23] (::KernelAbstractions.Kernel{CUDA.CUDAKernels.CUDABackend, KernelAbstractions.NDIteration.StaticSize{…}, KernelAbstractions.NDIteration.StaticSize{…}, typeof(Oceananigans.BoundaryConditions.gpu__no_fill!)})(::OffsetArrays.OffsetArray{Float64, 3, CUDA.CuArray{…}}, ::Vararg{Any})
    @ CUDA.CUDAKernels ~/.julia/packages/CUDA/Tl08O/src/CUDAKernels.jl:89
 [24] launch!(::GPU, ::ImmersedBoundaryGrid{…}, ::Tuple{…}, ::typeof(Oceananigans.BoundaryConditions._no_fill!), ::OffsetArrays.OffsetArray{…}, ::Vararg{…}; include_right_boundaries::Bool, reduced_dimensions::Tuple{}, location::Nothing, active_cells_map::Nothing, kwargs::@Kwargs{})
    @ Oceananigans.Utils /global/u1/a/alir/Oceananigans.jl/src/Utils/kernel_launching.jl:168
 [25] launch!
    @ /global/u1/a/alir/Oceananigans.jl/src/Utils/kernel_launching.jl:154 [inlined]
 [26] #fill_open_boundary_regions!#48
    @ /global/u1/a/alir/Oceananigans.jl/src/BoundaryConditions/fill_halo_regions_open.jl:20 [inlined]
 [27] fill_open_boundary_regions!
    @ /global/u1/a/alir/Oceananigans.jl/src/BoundaryConditions/fill_halo_regions_open.jl:9 [inlined]
 [28] fill_halo_regions!(::OffsetArrays.OffsetArray{…}, ::FieldBoundaryConditions{…}, ::Tuple{…}, ::Tuple{…}, ::ImmersedBoundaryGrid{…}; fill_boundary_normal_velocities::Bool, kwargs::@Kwargs{…})
    @ Oceananigans.BoundaryConditions /global/u1/a/alir/Oceananigans.jl/src/BoundaryConditions/fill_halo_regions.jl:53
 [29] fill_halo_regions!
    @ /global/u1/a/alir/Oceananigans.jl/src/BoundaryConditions/fill_halo_regions.jl:48 [inlined]
 [30] #fill_halo_regions!#61
    @ /global/u1/a/alir/Oceananigans.jl/src/Fields/field.jl:773 [inlined]
 [31] fill_halo_regions!(::Field{Face, Center, Nothing, Nothing, ImmersedBoundaryGrid{…}, Tuple{…}, OffsetArrays.OffsetArray{…}, Float64, FieldBoundaryConditions{…}, Nothing, Oceananigans.Fields.FieldBoundaryBuffers{…}})
    @ Oceananigans.Fields /global/u1/a/alir/Oceananigans.jl/src/Fields/field.jl:770
 [32] fill_halo_regions!(::Tuple{Field{…}, Field{…}}; kwargs::@Kwargs{})
    @ Oceananigans.Fields /global/u1/a/alir/Oceananigans.jl/src/Fields/field_tuples.jl:64
 [33] fill_halo_regions!(::Tuple{Field{…}, Field{…}})
    @ Oceananigans.Fields /global/u1/a/alir/Oceananigans.jl/src/Fields/field_tuples.jl:56
 [34] Oceananigans.Models.HydrostaticFreeSurfaceModels.SplitExplicitAuxiliaryFields(grid::ImmersedBoundaryGrid{Float64, Periodic, Flat, Bounded, RectilinearGrid{…}, PartialCellBottom{…}, Nothing, Nothing, GPU})
    @ Oceananigans.Models.HydrostaticFreeSurfaceModels /global/u1/a/alir/Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/split_explicit_free_surface.jl:239
 [35] materialize_free_surface(free_surface::SplitExplicitFreeSurface{…}, velocities::@NamedTuple{…}, grid::ImmersedBoundaryGrid{…})
    @ Oceananigans.Models.HydrostaticFreeSurfaceModels /global/u1/a/alir/Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/split_explicit_free_surface.jl:121
 [36] HydrostaticFreeSurfaceModel(; grid::ImmersedBoundaryGrid{…}, clock::Clock{…}, momentum_advection::Centered{…}, tracer_advection::Centered{…}, buoyancy::Nothing, coriolis::Nothing, free_surface::SplitExplicitFreeSurface{…}, tracers::Nothing, forcing::@NamedTuple{}, closure::Nothing, boundary_conditions::@NamedTuple{}, particles::Nothing, biogeochemistry::Nothing, velocities::Nothing, pressure::Nothing, diffusivity_fields::Nothing, auxiliary_fields::@NamedTuple{})
    @ Oceananigans.Models.HydrostaticFreeSurfaceModels /global/u1/a/alir/Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/hydrostatic_free_surface_model.jl:177
 [37] top-level scope
    @ REPL[6]:1
Some type information was truncated. Use `show(err)` to see complete types.

simone-silvestri · 2024-08-29T16:42:39Z

Hmmm, I cannot reproduce it on the CPU with --check-bounds=yes. Perhaps it was fixed in the latest three commits?

Oceananigans.jl/src/ImmersedBoundaries/partial_cell_bottom.jl

Lines 155 to 161 in 0fd3986

    
           @inline Δzᶠᶜᶜ(i, j, k, ibg::XFlatPCBIBG) = Δzᶜᶜᶜ(i, j, k, ibg) 
        
           @inline Δzᶠᶜᶠ(i, j, k, ibg::XFlatPCBIBG) = Δzᶜᶜᶠ(i, j, k, ibg) 
        
           @inline Δzᶜᶠᶜ(i, j, k, ibg::YFlatPCBIBG) = Δzᶜᶜᶜ(i, j, k, ibg) 
        
           @inline Δzᶜᶠᶠ(i, j, k, ibg::YFlatPCBIBG) = Δzᶜᶜᶠ(i, j, k, ibg) 
        
           @inline Δzᶠᶠᶜ(i, j, k, ibg::XFlatPCBIBG) = Δzᶜᶠᶜ(i, j, k, ibg) 
        
           @inline Δzᶠᶠᶜ(i, j, k, ibg::YFlatPCBIBG) = Δzᶠᶜᶜ(i, j, k, ibg)

ali-ramadhan · 2024-08-29T16:44:03Z

I was able to reproduce on the CPU with --check-bounds=yes but on the main branch. Lemme try on this branch.

Stacktrace from main for reference:

julia> using Oceananigans

julia> using Oceananigans.ImmersedBoundaries: PartialCellBottom

julia> underlying_grid = RectilinearGrid(CPU(), topology=(Periodic, Flat, Bounded), size=(4, 4), x=(0, 1), z=(0, 1))
4×1×4 RectilinearGrid{Float64, Periodic, Flat, Bounded} on CPU with 3×0×3 halo
├── Periodic x ∈ [0.0, 1.0) regularly spaced with Δx=0.25
├── Flat y                  
└── Bounded  z ∈ [0.0, 1.0] regularly spaced with Δz=0.25

julia> slope(x) = x
slope (generic function with 1 method)

julia> grid = ImmersedBoundaryGrid(underlying_grid, PartialCellBottom(slope))
4×1×4 ImmersedBoundaryGrid{Float64, Periodic, Flat, Bounded} on CPU with 3×0×3 halo:
├── immersed_boundary: PartialCellBottom(mean(z)=0.5, min(z)=0.125, max(z)=0.875, ϵ=0.2)
├── underlying_grid: 4×1×4 RectilinearGrid{Float64, Periodic, Flat, Bounded} on CPU with 3×0×3 halo
├── Periodic x ∈ [0.0, 1.0) regularly spaced with Δx=0.25
├── Flat y                  
└── Bounded  z ∈ [0.0, 1.0] regularly spaced with Δz=0.25

julia> model = HydrostaticFreeSurfaceModel(; grid)
ERROR: BoundsError: attempt to access 10×1×1 OffsetArray(::Array{Float64, 3}, -2:7, 1:1, 1:1) with eltype Float64 with indices -2:7×1:1×1:1 at index [1, 0, 1]
Stacktrace:
  [1] throw_boundserror(A::OffsetArrays.OffsetArray{Float64, 3, Array{Float64, 3}}, I::Tuple{Int64, Int64, Int64})
    @ Base ./abstractarray.jl:737
  [2] checkbounds
    @ ./abstractarray.jl:702 [inlined]
  [3] getindex
    @ ~/.julia/packages/OffsetArrays/hwmnB/src/OffsetArrays.jl:422 [inlined]
  [4] getindex
    @ ~/atdepth/Oceananigans.jl/src/Fields/field.jl:541 [inlined]
  [5] Δzᶜᶜᶜ
    @ ~/atdepth/Oceananigans.jl/src/ImmersedBoundaries/partial_cell_bottom.jl:115 [inlined]
  [6] Δzᶜᶠᶜ
    @ ~/atdepth/Oceananigans.jl/src/ImmersedBoundaries/partial_cell_bottom.jl:141 [inlined]
  [7] getindex
    @ ~/atdepth/Oceananigans.jl/src/AbstractOperations/grid_metrics.jl:138 [inlined]
  [8] getindex
    @ ~/atdepth/Oceananigans.jl/src/AbstractOperations/conditional_operations.jl:101 [inlined]
  [9] _getindex
    @ ./abstractarray.jl:1341 [inlined]
 [10] getindex
    @ ./abstractarray.jl:1291 [inlined]
 [11] macro expansion
    @ ./reducedim.jl:317 [inlined]
 [12] macro expansion
    @ ./simdloop.jl:77 [inlined]
 [13] _mapreducedim!(f::typeof(identity), op::typeof(Base.add_sum), R::SubArray{…}, A::Oceananigans.AbstractOperations.ConditionalOperation{…})
    @ Base ./reducedim.jl:316
 [14] mapreducedim!(f::Function, op::Function, R::SubArray{…}, A::Oceananigans.AbstractOperations.ConditionalOperation{…})
    @ Base ./reducedim.jl:324
 [15] sum!(f::Function, r::SubArray{…}, A::Oceananigans.AbstractOperations.ConditionalOperation{…})
    @ Base ./reducedim.jl:1034
 [16] sum!(r::Field{…}, a::Oceananigans.AbstractOperations.GridMetricOperation{…}; condition::Nothing, mask::Int64, kwargs::@Kwargs{})
    @ Oceananigans.Fields ~/atdepth/Oceananigans.jl/src/Fields/field.jl:696
 [17] sum!(r::Field{…}, a::Oceananigans.AbstractOperations.GridMetricOperation{…})
    @ Oceananigans.Fields ~/atdepth/Oceananigans.jl/src/Fields/field.jl:690
 [18] Oceananigans.Models.HydrostaticFreeSurfaceModels.SplitExplicitAuxiliaryFields(grid::ImmersedBoundaryGrid{Float64, Periodic, Flat, Bounded, RectilinearGrid{…}, PartialCellBottom{…}, Nothing, Nothing, CPU})
    @ Oceananigans.Models.HydrostaticFreeSurfaceModels ~/atdepth/Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/split_explicit_free_surface.jl:237
 [19] materialize_free_surface(free_surface::SplitExplicitFreeSurface{…}, velocities::@NamedTuple{…}, grid::ImmersedBoundaryGrid{…})
    @ Oceananigans.Models.HydrostaticFreeSurfaceModels ~/atdepth/Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/split_explicit_free_surface.jl:121
 [20] HydrostaticFreeSurfaceModel(; grid::ImmersedBoundaryGrid{…}, clock::Clock{…}, momentum_advection::Centered{…}, tracer_advection::Centered{…}, buoyancy::Nothing, coriolis::Nothing, free_surface::SplitExplicitFreeSurface{…}, tracers::Nothing, forcing::@NamedTuple{}, closure::Nothing, boundary_conditions::@NamedTuple{}, particles::Nothing, biogeochemistry::Nothing, velocities::Nothing, pressure::Nothing, diffusivity_fields::Nothing, auxiliary_fields::@NamedTuple{})
    @ Oceananigans.Models.HydrostaticFreeSurfaceModels ~/atdepth/Oceananigans.jl/src/Models/HydrostaticFreeSurfaceModels/hydrostatic_free_surface_model.jl:177
 [21] top-level scope
    @ REPL[6]:1
Some type information was truncated. Use `show(err)` to see complete types.

ali-ramadhan · 2024-08-29T16:48:20Z

Confirming that the MWE just above works on this branch on both CPU and GPU!

ali-ramadhan · 2024-08-29T16:58:30Z

Also confirming that my original MWE from #3681 also works on this branch now!

using Oceananigans
using Oceananigans.ImmersedBoundaries: PartialCellBottom

underlying_grid = RectilinearGrid(GPU(), topology=(Periodic, Flat, Bounded), size=(4, 4), x=(0, 1), z=(0, 1))
slope(x) = x
grid = ImmersedBoundaryGrid(underlying_grid, PartialCellBottom(slope))

model = HydrostaticFreeSurfaceModel(; grid)
time_step!(model, 1)

glwagner · 2024-09-25T00:47:45Z

What's keeping us from merging this? It fixes something so its a step forward, I think we should merge it.

…/adapt-bottom-height

glwagner · 2024-09-25T12:12:06Z

I implemented the clamping from #3787 and it seems to have fixed the issue:

GridFittedBottom

internal_tide_gf.mp4

PartialCellBottom

internal_tide_pc.mp4

I'm not sure I really understand why it would make a difference. I'm wondering @simone-silvestri are you sure that your test was using this code?

Either way I see no reason not to merge this. Perhaps we will continue to find improvements for PartialCellBottom but I think this is ready to be used in an example. Note that in the internal tide case the partial cells have the interesting effect of weakening the vertical velocity. That could make sense if the topography is somehow "less effectively steep" than in the full cell case.

glwagner · 2024-09-25T12:14:29Z

This PR now supercedes #3787

…ananigans.jl into ss/adapt-bottom-height

francispoulin · 2024-09-29T15:46:56Z

Now we have merged, should I revisit #3529?

glwagner · 2024-09-29T15:57:02Z

It's a good idea! Also @apaloczy had some tests that might be good to try to re-run.

glwagner · 2024-09-29T16:00:01Z

I suspect it won't change anything though because this PR fixes a bug that affects when criteria about the minimum fractional cell height is met. I don't think that criteria is met in your example (which is good)

fix a bug in the adapt

d9529a2

simone-silvestri mentioned this pull request Aug 8, 2024

Validation tests for immersed boundary implementations #775

Open

simone-silvestri added 3 commits August 7, 2024 20:09

Merge branch 'main' into ss/adapt-bottom-height

0992e0a

first fix

6e5b307

Merge branch 'main' into ss/adapt-bottom-height

1bdf889

navidcy added bug 🐞 Even a perfect program still has bugs GPU 👾 Where Oceananigans gets its powers from labels Aug 9, 2024

Merge branch 'main' into ss/adapt-bottom-height

f1f249d

Merge branch 'main' into ss/adapt-bottom-height

292f556

tomchor reviewed Aug 16, 2024

View reviewed changes

Merge branch 'main' into ss/adapt-bottom-height

6b47133

simone-silvestri added 2 commits August 29, 2024 11:00

bugfix

ed6d252

these should be all the bugs, still need to add the tests

ffca52b

another bugfix

0fd3986

ali-ramadhan mentioned this pull request Aug 29, 2024

Should tests be run with julia --check-bounds=yes? #3747

Closed

simone-silvestri added 2 commits August 29, 2024 15:41

Merge branch 'main' into ss/adapt-bottom-height

c55f8c3

Merge branch 'main' into ss/adapt-bottom-height

ee46994

simone-silvestri added the 🚨 DO NOT MERGE 🚨 IN BIG BOLD RED CAPS WITH FLASHING SIRENS label Sep 4, 2024

glwagner added 2 commits September 24, 2024 18:47

Merge branch 'main' into ss/adapt-bottom-height

9c00248

Clamp bottom_height to top and bottom of grid

0ed035b

glwagner mentioned this pull request Sep 25, 2024

Clamp immersed boundary bottom_height to top and bottom of grid #3787

Closed

Bugfix

00ffa57

glwagner approved these changes Sep 25, 2024

View reviewed changes

Merge remote-tracking branch 'origin/glw/clamp-bottom-height' into ss…

e8f6bc3

…/adapt-bottom-height

glwagner added 2 commits September 25, 2024 06:12

Implement clamping for both GF and PC bottom

2ed8f01

Convert internal tide example to use extension

a200fd0

glwagner and others added 4 commits September 25, 2024 07:10

apply_regionally *sigh*

47eeff0

Merge branch 'main' into ss/adapt-bottom-height

6f796a4

Disambiguate

9b1244a

Merge branch 'ss/adapt-bottom-height' of https://github.com/CliMA/Oce…

7ccd608

…ananigans.jl into ss/adapt-bottom-height

simone-silvestri removed the 🚨 DO NOT MERGE 🚨 IN BIG BOLD RED CAPS WITH FLASHING SIRENS label Sep 25, 2024

simone-silvestri and others added 3 commits September 25, 2024 12:35

using CairoMakie

9807bd0

Merge branch 'main' into ss/adapt-bottom-height

8d79478

Merge branch 'main' into ss/adapt-bottom-height

0f39bc8

glwagner merged commit 675e0ba into main Sep 27, 2024
46 checks passed

glwagner changed the title ~~Fix a bug in the adapt of PartialCellBottom~~ Fix _immered_cell and adapt for PartialCellBottom Sep 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `_immered_cell` and adapt for `PartialCellBottom` #3682

Fix `_immered_cell` and adapt for `PartialCellBottom` #3682

simone-silvestri commented Aug 5, 2024

glwagner commented Aug 5, 2024

glwagner commented Aug 5, 2024

glwagner commented Aug 14, 2024

tomchor Aug 16, 2024

simone-silvestri Aug 16, 2024

francispoulin Aug 19, 2024

glwagner commented Aug 19, 2024

simone-silvestri commented Aug 19, 2024

glwagner commented Aug 19, 2024

simone-silvestri commented Aug 29, 2024

simone-silvestri commented Aug 29, 2024

ali-ramadhan commented Aug 29, 2024 •

edited

Loading

simone-silvestri commented Aug 29, 2024

ali-ramadhan commented Aug 29, 2024 •

edited

Loading

ali-ramadhan commented Aug 29, 2024

ali-ramadhan commented Aug 29, 2024

glwagner commented Sep 25, 2024

glwagner commented Sep 25, 2024

glwagner commented Sep 25, 2024

francispoulin commented Sep 29, 2024

glwagner commented Sep 29, 2024

glwagner commented Sep 29, 2024

Fix _immered_cell and adapt for PartialCellBottom #3682

Fix _immered_cell and adapt for PartialCellBottom #3682

Conversation

simone-silvestri commented Aug 5, 2024

glwagner commented Aug 5, 2024

glwagner commented Aug 5, 2024

glwagner commented Aug 14, 2024

tomchor Aug 16, 2024

Choose a reason for hiding this comment

simone-silvestri Aug 16, 2024

Choose a reason for hiding this comment

francispoulin Aug 19, 2024

Choose a reason for hiding this comment

glwagner commented Aug 19, 2024

simone-silvestri commented Aug 19, 2024

glwagner commented Aug 19, 2024

simone-silvestri commented Aug 29, 2024

simone-silvestri commented Aug 29, 2024

ali-ramadhan commented Aug 29, 2024 • edited Loading

simone-silvestri commented Aug 29, 2024

ali-ramadhan commented Aug 29, 2024 • edited Loading

ali-ramadhan commented Aug 29, 2024

ali-ramadhan commented Aug 29, 2024

glwagner commented Sep 25, 2024

glwagner commented Sep 25, 2024

GridFittedBottom

PartialCellBottom

glwagner commented Sep 25, 2024

francispoulin commented Sep 29, 2024

glwagner commented Sep 29, 2024

glwagner commented Sep 29, 2024

Fix `_immered_cell` and adapt for `PartialCellBottom` #3682

Fix `_immered_cell` and adapt for `PartialCellBottom` #3682

ali-ramadhan commented Aug 29, 2024 •

edited

Loading

ali-ramadhan commented Aug 29, 2024 •

edited

Loading