Tr/minor tempest regridder changes #140
Draft
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sbozzolo
reviewed
Dec 12, 2024
| @@ -72,10 +72,10 @@ function Regridders.TempestRegridder( | |||
| input_file::AbstractString; | |||
| regrid_dir::AbstractString, | |||
| mono::Bool = true, | |||
| outfile_root::AbstractString = "cgll", | |||
There was a problem hiding this comment.
There is no real need for this to be a kwarg, or outfile_root to be changed in general.
Files saved during Regridding currently have a name structure as
hd_outfile_root * "_" * varname * "_" * string(time) * ".hdf5"
but hd_outfile_root is automatically set to varname, so the path becomes
varname * "_" * varname * "_" * string(time) * ".hdf5"
, which seems odd to me. The changes/potential changes in this PR came up in this PR
There was a problem hiding this comment.
Ah okay! I guess we can directly removed the hd_outfile_root then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To-do
Content