Improve notation for computing turbulent fluxes

[glwagner]

This PR is a WIP because I think we should have an interface for optionally including gustiness.

[glwagner]

Actually I think the gusintess should be part of the bulk_velocity

[glwagner]

A few more changes --- I think the fields should be outside the similarity theory fluxes probably. It'd be nice to have the option to toggle on and off all of the fluxes including the outgoing longwave and outgoing / reflected shortwave for example... even though some of these can be recomputed based on surface temperature

[simone-silvestri]

makes sense to have fields in OceanSeaIceSurfaceFluxes instead of SimilarityTheoryTurbulentFluxes.
the gustiness is optional for the moment by setting gustiness_parameter = 0. I am not really sure about including it in the bulk velocity because it is really a parameter of the similarity theory, it depends on a buoyancy scale.

[glwagner]

makes sense to have fields in OceanSeaIceSurfaceFluxes instead of SimilarityTheoryTurbulentFluxes. the gustiness is optional for the moment by setting gustiness_parameter = 0. I am not really sure about including it in the bulk velocity because it is really a parameter of the similarity theory, it depends on a buoyancy scale.

Why does it matter whether it is a parameter of similarity theory?

The bulk_velocity represents how we compute the velocity scale that enters into bulk formula, which have a form

u★ θ★ = C * Δθ * U

where U is the bulk velocity scale. The reason for this abstraction is because there are a few different parameterizations for U. For example, some models ignore the ocean velocity when computing U. Other models include a gustiness as here. One could consider additional parameterizations, perhaps dependent on the surface wave state.

What do you propose as a different intent for the purpose of the bulk_velocity property? I don't completely understand what you mean with your argument that the gustiness is not a parameter of the similarity theory. Should parameterizations of bulk_velocity only be specific to similarity theory? Why would we want to do that?

[simone-silvestri]

I meant that the gustiness gets "solved for" by iterating while the bulk velocity is calculated once at the beginning of the iteration, for that reason I meant that the gustiness is more related to the similarity theory than the bulk velocity, but we could recompute the velocity if using a bulk velocity that includes gustiness

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f52a6d6) to head (094b0d6).

Files	Patch %	Lines
...Models/CrossRealmFluxes/atmosphere_ocean_fluxes.jl	0.00%	24 Missing ⚠️
...sRealmFluxes/similarity_theory_turbulent_fluxes.jl	0.00%	11 Missing ⚠️
...aIceModels/CrossRealmFluxes/stability_functions.jl	0.00%	5 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main     #99   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         28      28           
  Lines       1585    1586    +1     
=====================================
- Misses      1585    1586    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glwagner]

needs review @simone-silvestri