Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scratch for Bathymetry #95

Merged
merged 12 commits into from
Jul 4, 2024
Merged

Use Scratch for Bathymetry #95

merged 12 commits into from
Jul 4, 2024

Conversation

vchuravy
Copy link
Contributor

The current directory might not be writeable and this way multiple copies of the code can share the same data.

It might make sense to use something like DataDeps/Artifacts in the long run.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (dc7a775) to head (4fb7bc9).

Files Patch % Lines
src/DataWrangling/JRA55.jl 0.00% 11 Missing ⚠️
src/Bathymetry.jl 0.00% 2 Missing ⚠️
src/OceanSimulations/OceanSimulations.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #95   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         28      28           
  Lines       1580    1585    +5     
=====================================
- Misses      1580    1585    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy
Copy link
Contributor Author

Probably also need to do something similar for RYF.*

@glwagner
Copy link
Member

cc @simone-silvestri

@simone-silvestri
Copy link
Collaborator

Looks good! should we include a scratch for the JRA55-downloaded files in this PR?

@glwagner
Copy link
Member

Looks good! should we include a scratch for the JRA55-downloaded files in this PR?

yes

@glwagner
Copy link
Member

glwagner commented Jul 2, 2024

@simone-silvestri please review this

@simone-silvestri simone-silvestri merged commit f52a6d6 into main Jul 4, 2024
9 checks passed
@simone-silvestri simone-silvestri deleted the vc/scratch branch July 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants