Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notation for computing turbulent fluxes #99

Merged
merged 12 commits into from
Jul 11, 2024

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Jul 1, 2024

This PR is a WIP because I think we should have an interface for optionally including gustiness.

@glwagner glwagner marked this pull request as draft July 1, 2024 22:46
@glwagner
Copy link
Member Author

glwagner commented Jul 2, 2024

Actually I think the gusintess should be part of the bulk_velocity

@glwagner glwagner marked this pull request as ready for review July 2, 2024 19:11
@glwagner
Copy link
Member Author

glwagner commented Jul 2, 2024

A few more changes --- I think the fields should be outside the similarity theory fluxes probably. It'd be nice to have the option to toggle on and off all of the fluxes including the outgoing longwave and outgoing / reflected shortwave for example... even though some of these can be recomputed based on surface temperature

@simone-silvestri
Copy link
Collaborator

makes sense to have fields in OceanSeaIceSurfaceFluxes instead of SimilarityTheoryTurbulentFluxes.
the gustiness is optional for the moment by setting gustiness_parameter = 0. I am not really sure about including it in the bulk velocity because it is really a parameter of the similarity theory, it depends on a buoyancy scale.

@glwagner
Copy link
Member Author

glwagner commented Jul 3, 2024

makes sense to have fields in OceanSeaIceSurfaceFluxes instead of SimilarityTheoryTurbulentFluxes. the gustiness is optional for the moment by setting gustiness_parameter = 0. I am not really sure about including it in the bulk velocity because it is really a parameter of the similarity theory, it depends on a buoyancy scale.

Why does it matter whether it is a parameter of similarity theory?

The bulk_velocity represents how we compute the velocity scale that enters into bulk formula, which have a form

u★ θ★ = C * Δθ * U

where U is the bulk velocity scale. The reason for this abstraction is because there are a few different parameterizations for U. For example, some models ignore the ocean velocity when computing U. Other models include a gustiness as here. One could consider additional parameterizations, perhaps dependent on the surface wave state.

What do you propose as a different intent for the purpose of the bulk_velocity property? I don't completely understand what you mean with your argument that the gustiness is not a parameter of the similarity theory. Should parameterizations of bulk_velocity only be specific to similarity theory? Why would we want to do that?

@simone-silvestri
Copy link
Collaborator

I meant that the gustiness gets "solved for" by iterating while the bulk velocity is calculated once at the beginning of the iteration, for that reason I meant that the gustiness is more related to the similarity theory than the bulk velocity, but we could recompute the velocity if using a bulk velocity that includes gustiness

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f52a6d6) to head (094b0d6).

Files Patch % Lines
...Models/CrossRealmFluxes/atmosphere_ocean_fluxes.jl 0.00% 24 Missing ⚠️
...sRealmFluxes/similarity_theory_turbulent_fluxes.jl 0.00% 11 Missing ⚠️
...aIceModels/CrossRealmFluxes/stability_functions.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #99   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         28      28           
  Lines       1585    1586    +1     
=====================================
- Misses      1585    1586    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glwagner
Copy link
Member Author

glwagner commented Jul 9, 2024

needs review @simone-silvestri

@glwagner glwagner merged commit 94c53eb into main Jul 11, 2024
9 checks passed
@glwagner glwagner deleted the glw/clarify-turbulent-fluxes branch July 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants