Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImmersedBoundaryCondition for drag, take 2 #137

Merged
merged 27 commits into from
Nov 10, 2024

Conversation

simone-silvestri
Copy link
Collaborator

This PR is a cleaner version of #130, removing the forcing for drag above topography in favor of ImmersedBoundaryCondition

closes #130

@simone-silvestri simone-silvestri added the Built Docs Add this label to built the docs in a PR label Aug 14, 2024
simone-silvestri and others added 3 commits August 14, 2024 13:24
…liMA/ClimaOcean.jl into ss/immersed-boundary-conditions-take-2
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2e3ce57) to head (7f4217e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/OceanSimulations/OceanSimulations.jl 0.00% 15 Missing ⚠️
src/DataWrangling/ECCO/ECCO_mask.jl 0.00% 14 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #137   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         32      32           
  Lines       1823    1843   +20     
=====================================
- Misses      1823    1843   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glwagner
Copy link
Member

glwagner commented Nov 8, 2024

@simone-silvestri can you push this through

@simone-silvestri
Copy link
Collaborator Author

There seems to be a problem with the example. I will try it locally

@simone-silvestri simone-silvestri merged commit ff9366b into main Nov 10, 2024
7 checks passed
@simone-silvestri simone-silvestri deleted the ss/immersed-boundary-conditions-take-2 branch November 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Built Docs Add this label to built the docs in a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants