Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dss_state! function #442

Merged
merged 1 commit into from
Oct 3, 2023
Merged

add dss_state! function #442

merged 1 commit into from
Oct 3, 2023

Conversation

juliasloan25
Copy link
Member

Purpose

Use new dss_state! function to check that initial conditions are continuous

Closes #435

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 mentioned this pull request Sep 29, 2023
Closed
LenkaNovak
LenkaNovak requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @juliasloan25 , thank you for this PR! Here are some comments on generality and placing. Happy to chat if needs be.

experiments/AMIP/modular/coupler_driver_modular.jl Outdated Show resolved Hide resolved
src/Interfacer.jl Outdated Show resolved Hide resolved
test/interfacer_tests.jl Outdated Show resolved Hide resolved
LenkaNovak
LenkaNovak reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Julia, this looks great! Just a couple of clarifications on package imports, and the Atmos dss + tests should really be dispatched on ClimaAtmosSimulation, since the component tests are supposed to test the specific component models. Otherwise the assumption would be that all future atmos models will need this dss function.

LenkaNovak
LenkaNovak approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@LenkaNovak LenkaNovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliasloan25
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Oct 2, 2023
@bors @juliasloan25
Merge #442
f6072fb 
442: add dss_state! function r=juliasloan25 a=juliasloan25



Co-authored-by: Julia Sloan <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 3, 2023

Build failed:

@juliasloan25
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 23f3f3f into main Oct 3, 2023
8 checks passed
@bors bors bot deleted the js/dss_states branch October 3, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenkaNovak LenkaNovak LenkaNovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that initial conditions are continuous fields
2 participants
@juliasloan25 @LenkaNovak