Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp ConservationChecker #436

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Revamp ConservationChecker #436

merged 1 commit into from
Sep 26, 2023

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Sep 25, 2023 •
edited
Loading

Purpose

Closes #404

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak mentioned this pull request Sep 25, 2023
Closed
9 tasks
@LenkaNovak LenkaNovak marked this pull request as ready for review September 26, 2023 15:14
@LenkaNovak LenkaNovak force-pushed the ln/fix-water-cons2 branch 2 times, most recently from 0b10b55 to 04adccf Compare September 26, 2023 16:46
@LenkaNovak LenkaNovak mentioned this pull request Sep 26, 2023
Closed
1 task
juliasloan25
juliasloan25 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had a few questions, mostly about clarifying comments :)

experiments/AMIP/modular/components/atmosphere/climaatmos_init.jl Show resolved Hide resolved
experiments/AMIP/modular/components/atmosphere/climaatmos_init.jl Show resolved Hide resolved
experiments/AMIP/modular/components/land/bucket_utils.jl Outdated Show resolved Hide resolved
experiments/AMIP/modular/components/ocean/slab_ocean_init.jl Show resolved Hide resolved
src/ConservationChecker.jl Show resolved Hide resolved
src/ConservationChecker.jl Show resolved Hide resolved
src/ConservationChecker.jl Show resolved Hide resolved
test/conservation_checker_tests.jl Show resolved Hide resolved
@LenkaNovak
revamp ConservationChecker
02906c4 
add to driver

add to driver

conserves

clean up

disable limiters

clean up

revs
@LenkaNovak
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 26, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a6a1aeb into main Sep 26, 2023
@bors bors bot deleted the ln/fix-water-cons2 branch September 26, 2023 23:48
This was referenced Oct 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliasloan25 juliasloan25 juliasloan25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check water conservation (incl. snow)
2 participants
@LenkaNovak @juliasloan25