Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back Semtner Sea Ice #403

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Bring back Semtner Sea Ice #403

merged 1 commit into from
Oct 3, 2023

Conversation

LenkaNovak
Copy link
Collaborator

@LenkaNovak LenkaNovak commented Aug 21, 2023 •
edited
Loading

Closes #402

  • I have read and checked the items on the review checklist.

@LenkaNovak LenkaNovak force-pushed the ln/bring-back-semtner branch 2 times, most recently from 3439a83 to e51b419 Compare September 8, 2023 23:46
@LenkaNovak LenkaNovak requested a review from glwagner September 8, 2023 23:46
@LenkaNovak LenkaNovak marked this pull request as ready for review September 8, 2023 23:46
@LenkaNovak LenkaNovak force-pushed the ln/bring-back-semtner branch from 04b3fa6 to 85e1afe Compare September 18, 2023 23:39
@LenkaNovak LenkaNovak force-pushed the ln/bring-back-semtner branch 6 times, most recently from 986ac7a to 8b49ce8 Compare October 3, 2023 03:27
glwagner
glwagner reviewed Oct 3, 2023
View reviewed changes
src/FluxCalculator.jl Outdated Show resolved Hide resolved
@LenkaNovak LenkaNovak force-pushed the ln/bring-back-semtner branch from 8b49ce8 to 4835942 Compare October 3, 2023 14:43
@LenkaNovak
step works
d5a1359 
revamp model + unit tests

runs in AMIP driver

clean

step works

ice runs from driver with dss

name switch

delete redundant directory

add ocean params

add to CI pipeline

sea ice animation

format

unit test fixes

test for differentiate_turbulent_fluxes!

add artifacts to buildkite

dss q_sfc, solving tropical instability

shorten t_end for ci

format

fix test

dep fix

new hdf5 paths

step works

revamp model + unit tests

runs in AMIP driver

clean

step works

ice runs from driver with dss

name switch

delete redundant directory

add ocean params

add to CI pipeline

sea ice animation

format

unit test fixes

test for differentiate_turbulent_fluxes!

add artifacts to buildkite

dss q_sfc, solving tropical instability

shorten t_end for ci

format

fix test

dep fix

revs

revs + HPC pipeline fix

rebase

clean up

clean up

vert_diff param fix

doc fix

rev

rebase

clean
@LenkaNovak LenkaNovak force-pushed the ln/bring-back-semtner branch from 4835942 to d5a1359 Compare October 3, 2023 15:25
@LenkaNovak
Copy link
Collaborator Author

bors try

bors bot added a commit that referenced this pull request Oct 3, 2023
@bors
Try #403:
a0ac368
@bors
Copy link
Contributor

bors bot commented Oct 3, 2023

try

Build failed:

@LenkaNovak
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a8a6c58 into main Oct 3, 2023
@bors bors bot deleted the ln/bring-back-semtner branch October 3, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring Back Semtner Sea Ice
2 participants
@LenkaNovak @glwagner