-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use time-varying albedo in bucket #394
Conversation
1cc7338
to
c61c828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Julia! Buildkite output looks good, but I noticed that the logging doesn't display the run command log (apparently the limit was exceeded). From your local runs, is it obvious why that is? (e.g., lots of warning messages?)
@LenkaNovak I've actually been getting a |
Is it the same as these failures that I've seen in my other |
It's similar, but it's a different TempestRemap call that's failing. Here are some screenshots of the error and stacktrace: |
2dd9d1e
to
0d9f730
Compare
0d9f730
to
9fd1d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you, @juliasloan25 !
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Purpose
Closes #318
Edit: The interface for
ClimaLSM.Bucket.BulkAlbedoTemporal
needed to change for compatibility with the coupler. This change has been made in CliMA/ClimaLand.jl#300. ClimaLSM.jl has made an additional patch release for this change, bringing it up to v0.3.1.To Do
The changes made here will be similar to those made in #202 for reading in albedo from a constant map
v0.3.0v0.3.1albedo_type
option