Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sim_mode only in init #1153

Merged
merged 2 commits into from
Feb 5, 2025
Merged

use sim_mode only in init #1153

merged 2 commits into from
Feb 5, 2025

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Jan 28, 2025

Purpose

Remove all uses of sim_mode after initialization, which was mostly in postprocessing/diagnostics. Note that now all available diagnostics will be plotted at the end of the simulation, where before we specified a subset to plot based on the simulation type.

closes #1138

To-do

  • check CI output diagnostics

Content

  • shared postprocessing for slabplanet and AMIP simulation types
  • rename amip_diags_handler -> diags_handler
  • delete plot_diagnostics config option (redundant with use_coupler_diagnostics)
  • remove mode_specifics from CoupledSimulation altogether
  • rename amip_diagnostics_setup to coupler_diagnostics_setup

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/simmode branch 9 times, most recently from 8cef522 to 3091d5c Compare February 5, 2025 02:46
@juliasloan25 juliasloan25 merged commit 41a831b into main Feb 5, 2025
10 of 11 checks passed
@juliasloan25 juliasloan25 deleted the js/simmode branch February 5, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit sim_mode use in driver to init
2 participants