Remove unused direct dependencies #1103
Conversation
imreddyTeja
force-pushed
the
tr/clean-project-tomls
branch
4 times, most recently
from
4cc8bac to
f3628e5
Compare
imreddyTeja
force-pushed
the
tr/clean-project-tomls
branch
2 times, most recently
from
67722e9 to
1a440fd
Compare
| ClimaAtmos = "b2c96348-7fb7-4fe0-8da9-78d88439e717" | ||
| ClimaComms = "3a4d1b5c-c61d-41fd-a00a-5873ba7a1b0d" | ||
| ClimaCore = "d414da3d-4745-48bb-8d80-42e94e092884" | ||
| ClimaCoreMakie = "908f55d8-4145-4867-9c14-5dad1a479e4d" | ||
| ClimaCoupler = "4ade58fe-a8da-486c-bd89-46df092ec0c7" | ||
| ClimaLand = "08f4d4ce-cf43-44bb-ad95-9d2d5f413532" | ||
| ClimaParams = "5c42b081-d73a-476f-9059-fd94b934656c" | ||
| ClimaTimeSteppers = "595c0a79-7f3d-439a-bc5a-b232dc3bde79" |
There was a problem hiding this comment.
From your comment in #1075, it looks like ClimaTimeSteppers, IntervalSets, LinearAlgebra, SciMLBase, and Statistics can also be removed. These are indirect dependencies, so if you're planning to do them in a separate PR that's fine, but I see that this PR removes the indirect dependencies in the experiments/ClimaEarth/ environment, so maybe you could do them all at once. Whichever is easiest for you!
There was a problem hiding this comment.
My comment in #1075 was incorrect about a few things.
For experiments/ClimaEarth, Interpolations.jl cannot be removed as a direct dependency because it is used once in plot_helper.jl.
For test, ClimaTimeSteppers, IntervalSets, LinearAlgebra, SciMLBase, and Statistics cannot be removed as direct dependencies, because they are imported in scripts in experiments/ClimaEarth, which are then include-ed in tests in test.
I've updated the comment reflect this
There was a problem hiding this comment.
IntervalSets can be often removed with small changes
There was a problem hiding this comment.
IntervalSets now removed.
imreddyTeja
force-pushed
the
tr/clean-project-tomls
branch
2 times, most recently
from
dc619a1 to
b70b366
Compare
imreddyTeja
force-pushed
the
tr/clean-project-tomls
branch
from
b70b366 to
d1f3f1b
Compare
* Remove unused direct dependencies * Remove indirect dependencies from Project.tomls
Purpose
Closes #1075
To-do
Content