Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all steps in buildkite pipeline use reservation #3597

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Feb 5, 2025

Purpose

There were five steps in the build kite pipeline that did not use the slurm reservation:

  1. Calibration interface unit tests
  2. CPU perf target (Threaded)
  3. Flame graph: perf target (frierson diffusion)
  4. Flame graph: perf target (Threaded)
  5. Flame graph: perf target (prognostic edmfx aquaplanet)

To-do

Content

The above steps were modified as following:

  1. moved to new pipeline
  2. removed
  3. removed
  4. removed
  5. slurm memory reduced to 32GB.

  • I have read and checked the items on the review checklist.

@imreddyTeja imreddyTeja force-pushed the tr/update-buildkite-pipelien branch from 0e5926f to b2ed4b4 Compare February 5, 2025 19:57
slurm_mem: 8G
modules: climacommon/2024_12_16
env:
JULIA_LOAD_PATH: "${JULIA_LOAD_PATH}:${BUILDKITE_BUILD_CHECKOUT_PATH}/.buildkite"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

Comment on lines 12 to 15
CONFIG_PATH: "config/model_configs"
GPU_CONFIG_PATH: "config/gpu_configs"
PERF_CONFIG_PATH: "config/perf_configs"
MPI_CONFIG_PATH: "config/mpi_configs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are also not needed

Comment on lines 26 to 34
- "julia --project -e 'using Pkg; Pkg.instantiate(;verbose=true)'"
- "julia --project -e 'using Pkg; Pkg.precompile()'"
- "julia --project -e 'using Pkg; Pkg.status()'"

- echo "--- Instantiate .buildkite"
- "julia --project=.buildkite -e 'using Pkg; Pkg.instantiate(;verbose=true)'"
- "julia --project=.buildkite -e 'using Pkg; Pkg.precompile()'"
- "julia --project=.buildkite -e 'using CUDA; CUDA.precompile_runtime()'"
- "julia --project=.buildkite -e 'using Pkg; Pkg.status()'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In here, we only need the calibration env

Comment on lines 64 to 65
- wait: ~
continue_on_failure: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

@imreddyTeja imreddyTeja force-pushed the tr/update-buildkite-pipelien branch from 28a943e to 37c31a7 Compare February 5, 2025 20:13
@imreddyTeja imreddyTeja marked this pull request as ready for review February 5, 2025 20:16
@Sbozzolo Sbozzolo self-requested a review February 5, 2025 20:16
Reduce flame graph: perf target (prognostic edmfx aquaplanet)
memory to 32 GB, remove threaded benchmark and flame graph,
and move calibration to its own pipeline.

Update calibration pipeline
@imreddyTeja imreddyTeja force-pushed the tr/update-buildkite-pipelien branch from 37c31a7 to 3de7150 Compare February 5, 2025 20:18
@Sbozzolo Sbozzolo merged commit 098e794 into main Feb 5, 2025
3 of 5 checks passed
@Sbozzolo Sbozzolo deleted the tr/update-buildkite-pipelien branch February 5, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants