Working fluid part 2 - RHS updates #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
force-pushed
the
aj/working_fluid_part2_RHS
branch
3 times, most recently
from
0a8f10c to
d985a79
Compare
|
@szy21 - this is the microphysics 1M RHS update to the working fluid equations. LMK if you would prefer to merge it and work on the advection piece next (making 1M microphysics slightly inconsistent for a little bit) or if we should wait and work on advection on a separate branch. Also, I can clean up the cloud condensation by overwriting the parameter instead. I'll do it if we decide to actually try to merge it in |
trontrytel
force-pushed
the
aj/working_fluid_part2_RHS
branch
from
d985a79 to
7abcb49
Compare
szy21
reviewed
Feb 3, 2025
|
Thanks! I'll go ahead clean up and merge it in. And then do the same for the velocity. It''ll make it easier for testing to not have to juggle between branches so much |
trontrytel
force-pushed
the
aj/working_fluid_part2_RHS
branch
2 times, most recently
from
263a2dc to
0ffbf66
Compare
szy21
approved these changes
Feb 4, 2025
src/parameterized_tendencies/microphysics/microphysics_wrappers.jl
Outdated
Show resolved
Hide resolved
src/parameterized_tendencies/microphysics/microphysics_wrappers.jl
Outdated
Show resolved
Hide resolved
trontrytel
force-pushed
the
aj/working_fluid_part2_RHS
branch
from
0ffbf66 to
0768899
Compare
trontrytel
force-pushed
the
aj/working_fluid_part2_RHS
branch
from
0768899 to
8c4b13f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the updtaed RHS in the CI