-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YAML Linter GHA #2786
Add YAML Linter GHA #2786
Conversation
8350430
to
53550c2
Compare
53550c2
to
dfc8a7c
Compare
dfc8a7c
to
8b51851
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, maybe someone else can review this, too?
Can you post what the diff/output would look like? |
Here is some sample output - it is not as nice as the Julia formatter because it just lints instead of formatting. I am looking into yamlfmt for actual formatting |
1ccd8ee
to
151432e
Compare
@Sbozzolo I have gotten it to run the diff, here is some sample output below. The workflow log contains color for the diff as well. --- a/config/gpu_configs/gpu_aquaplanet_diagedmf.yml
+++ b/config/gpu_configs/gpu_aquaplanet_diagedmf.yml
@@ -7,23 +7,23 @@ z_max: 55000.0
z_elem: 63
dz_bottom: 30.0
dz_top: 3000.0
-moist: equil
-surface_setup: DefaultMoninObukhov
+moist: equil
+surface_setup: DefaultMoninObukhov
rad: allskywithclear
idealized_insolation: false
dt_rad: 1hours
dt_cloud_fraction: 1hours
-turbconv: diagnostic_edmfx
+turbconv: diagnostic_edmfx
implicit_diffusion: true |
If 90 % of what this code does is removing trailing spaces, I think we should set up something that removes trailing spaces from every file. We have tons of them. |
b6ccf63
to
7f7773e
Compare
21003f6
to
658e0a6
Compare
This PR adds a basic YAML linter to keep our config files clean.
Two open questions
pipeline.yml
?If people like this, I will format the YAML files nicely in this PR as well.