Add reasonable conversion from z to pressure #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 98.31% 98.32%
=======================================
Files 11 11
Lines 1188 1191 +3
=======================================
+ Hits 1168 1171 +3
Misses 20 20 ☔ View full report in Codecov by Sentry. |
Sbozzolo
reviewed
Nov 8, 2024
NEWS.md
Outdated
Comment on lines
31
to
33
| - `Atmos.to_pressure_coordinates` now uses reasonable pressure values when `target_pressure` | ||
| is not specified. In particular, the vertical dimension is mapped to pressure levels by | ||
| z -> P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0. |
There was a problem hiding this comment.
Suggested change
| - `Atmos.to_pressure_coordinates` now uses reasonable pressure values when `target_pressure` | |
| is not specified. In particular, the vertical dimension is mapped to pressure levels by | |
| z -> P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0. | |
| - `Atmos.to_pressure_coordinates` now uses reasonable pressure values when `target_pressure` | |
| is not specified. In particular, the vertical dimension is mapped to pressure levels by | |
| z -> P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0, following a simple | |
| hydrostatic model for the atmosphere. |
ph-kev
force-pushed
the
kp/update-pres-coords
branch
from
d62f185 to
7e715d9
Compare
Sbozzolo
approved these changes
Nov 11, 2024
NEWS.md
Outdated
| @@ -28,6 +28,10 @@ julia> ClimaAnalysis.global_rmse_pfull(sim_var, obs_var, sim_pressure = pressure | |||
|
|
|||
| ## Bug fixes | |||
| - `Atmos.to_pressure_coordinates` now works with Unitful units. | |||
| - `Atmos.to_pressure_coordinates` now uses reasonable pressure values when `target_pressure` | |||
| is not specified. In particular, the vertical dimension is mapped to pressure levels by z | |||
| -> P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0 , following a simple | |||
There was a problem hiding this comment.
Suggested change
| -> P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0 , following a simple | |
| -> P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0, following a simple |
To convert from z to pressure, we use p(z) = P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0.
ph-kev
force-pushed
the
kp/update-pres-coords
branch
from
7e715d9 to
27f4413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #157 - This commit adds a reasonable conversion from z to pressure by finding the target pressure by using the mapping p(z) = P0 * exp(-z / H_EARTH), where P0 = 10000 and H_EARTH = 7000.0.