Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows test failures #262

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Fix windows test failures #262

wants to merge 17 commits into from

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Dec 11, 2023

Purpose

Posted this issue to SciKitLearn.jl as it appears like it is on their side.

Content

  • Noticed that last week there was a patch update to v1.96.3 (breaking PR uses this) from v1.96.2 (working PR uses this). --- Result: Failure still on v1.96.2
  • Code breaks exactly when calling Fit in src/GaussianProcesses.jl: on call to PyGP.GaussianProcessRegressor?
  • added MWE.jl with simple constant kernel
  • Can update scipy 1.8.1 to 1.11.4 and scikitlearn 1.1.1 to 1.3.2 and tests still pass / fail as before.

  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a621a04) 88.09% compared to head (7abdb55) 88.20%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   88.09%   88.20%   +0.10%     
==========================================
  Files           7        8       +1     
  Lines        1134     1178      +44     
==========================================
+ Hits          999     1039      +40     
- Misses        135      139       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant