-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: tables V2 #749
refactor: tables V2 #749
Conversation
Codecov ReportBase: 23.57% // Head: 19.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 23.57% 19.11% -4.46%
==========================================
Files 60 70 +10
Lines 13291 13151 -140
==========================================
- Hits 3133 2514 -619
- Misses 10158 10637 +479
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
95e3c21
to
8c642d7
Compare
4616fbf
to
ef60e22
Compare
f93fb1c
to
0ce91d7
Compare
…emoving the last value and selected
work towards porting over CPU fix typo partially port over cpu, fix some potentially inefficient concat_string calls more work towards cpu widget migration some refactoring
sortable data more refactoring some sort refactoring more refactoringgggg column refactoring renaming and reorganizing more refactoring regarding column logic add sort arrows again
port over process precommit temp temp two, remember to squash work fix broken ltr calculation and CPU hiding add back row styling temp fix a bunch of issues, get proc working more fixes around click fix frozen issues
0ce91d7
to
a7f2364
Compare
3dfcca8
to
3d22846
Compare
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
Overview
This PR generally refactors the table and sortable table components, used by temp, disk, process, and CPU widgets.
Note most of the commits in this PR are going to be more of trial and error/testing things out, rather than proper commits. I'll probably squash some things as this approaches completion.
General goals
This PR started with the following goals in mind:
Other
main.rs
pipeline. Highly considering moving it into the config pipeline in the future.Issue
If applicable, what issue does this address?
Related to #374
Closes #773, closes #815
Testing
If relevant, please state how this was tested. All changes must be tested to work:
Please also indicate which platforms were tested. All platforms directly affected by the change must be tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, etc.)