Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] refactor: Rewrite drawing #534

Closed
wants to merge 3 commits into from
Closed

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jul 4, 2021

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Separate PR into the main state refactor branch PR (#488), specifically regarding a rewrite for drawing.

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Furthermore, mark which platforms this change was tested on. All platforms directly affected by the change must be tested

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts

@ClementTsang ClementTsang changed the title (WIP) refactor: Rewrite drawing [WIP] refactor: Rewrite drawing Jul 4, 2021
@ClementTsang ClementTsang force-pushed the rewrite_drawing branch 3 times, most recently from a6b1cca to c2a18be Compare July 12, 2021 05:09
@ClementTsang ClementTsang force-pushed the state_refactor branch 3 times, most recently from 20eb203 to 53da360 Compare July 14, 2021 23:15
@ClementTsang ClementTsang force-pushed the rewrite_drawing branch 2 times, most recently from e2b6435 to d410ce7 Compare July 14, 2021 23:17
 refactor: Remove a looot of redundant config code

refactor: Move some state content over

refactor: rename folder

refactor: More renaming and pruning of old unused code.

refactor: Create a prototype time graph element

Move some state content over

refactor: rename folder

refactor: More renaming and pruning of old unused code.

Create a prototype time graph element

scrollable table

Temporarily add dead code allows

Minor refactorings

refactor: Move current widgets to the new element system

squash this - WIP of re-refactor

Revert "squash this - WIP of re-refactor"

This reverts commit a3ce25732663863b1ba2ef8a764c57572406014f.

Revert "refactor: Move current widgets to the new element system"

This reverts commit c7218472c2ce6d1bebf5550aaf53c171d3cd7c3e.

WIP re-refactor

Revert "refactor: Create a prototype time graph element"

This reverts commit bd95ca8.

Revert "refactor: Create a prototype time graph element"

This reverts commit bd95ca8.

refactor: Create a prototype time graph element

Move some state content over

refactor: rename folder

refactor: More renaming and pruning of old unused code.

Create a prototype time graph element

scrollable table

Temporarily add dead code allows

Minor refactorings
@ClementTsang
Copy link
Owner Author

Going to close this for now and open again when it's closer to being ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant