Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix support for nilfs2 file system #1596

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

llc0930
Copy link
Contributor

@llc0930 llc0930 commented Sep 12, 2024

Description

Fix the problem that the nilfs2 file system partition is not displayed in the disk list.

Issue

Related discussions: #1595

Testing

If relevant, please state how this was tested. All changes must be tested to work:
2024-09-13-05:30:19-w

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Fix the problem that the nilfs2 file system partition is not displayed in the disk list.
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.86%. Comparing base (4e47f9b) to head (83dcf6b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1596       +/-   ##
===========================================
- Coverage   54.65%   41.86%   -12.79%     
===========================================
  Files         114      114               
  Lines       17672    17672               
===========================================
- Hits         9658     7398     -2260     
- Misses       8014    10274     +2260     
Flag Coverage Δ
macos-12 37.27% <100.00%> (ø)
ubuntu-latest 43.62% <100.00%> (-13.46%) ⬇️
windows-2019 37.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@ClementTsang
Copy link
Owner

@all-contributors please add @llc0930 for code.

Copy link
Contributor

@ClementTsang

I've put up a pull request to add @llc0930! 🎉

@ClementTsang ClementTsang merged commit fe25055 into ClementTsang:main Sep 13, 2024
36 checks passed
ClementTsang added a commit that referenced this pull request Sep 16, 2024
ClementTsang added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants