Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge mock + init job in nightly #1584

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Merges the two together as one step as it doesn't really make sense to separate the two.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang merged commit 2e5000e into main Sep 5, 2024
34 checks passed
@ClementTsang ClementTsang deleted the update_nightly_action_mock_init branch September 5, 2024 02:56
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.65%. Comparing base (6c42770) to head (34cc390).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1584       +/-   ##
===========================================
- Coverage   54.22%   41.65%   -12.57%     
===========================================
  Files         114      114               
  Lines       17893    17893               
===========================================
- Hits         9702     7453     -2249     
- Misses       8191    10440     +2249     
Flag Coverage Δ
macos-12 36.94% <ø> (ø)
ubuntu-latest 43.38% <ø> (-13.23%) ⬇️
windows-2019 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant