Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix a few actions #1583

Merged
merged 4 commits into from
Sep 5, 2024
Merged

ci: fix a few actions #1583

merged 4 commits into from
Sep 5, 2024

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

A few small things:

  • Tweak timeouts
  • Disable audit workflow as codecov mostly handles it now
  • Fix mock check in nightly

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) September 5, 2024 01:58
@ClementTsang ClementTsang enabled auto-merge (squash) September 5, 2024 01:58
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.65%. Comparing base (c9a9988) to head (35b8360).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   41.65%   41.65%   -0.01%     
==========================================
  Files         114      114              
  Lines       17893    17893              
==========================================
- Hits         7454     7453       -1     
- Misses      10439    10440       +1     
Flag Coverage Δ
macos-12 36.94% <ø> (ø)
ubuntu-latest 43.38% <ø> (-0.01%) ⬇️
windows-2019 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit 6c42770 into main Sep 5, 2024
33 checks passed
@ClementTsang ClementTsang deleted the fix_some_actions branch September 5, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant