fix: selected text bg in default-light theme #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage 41.65% 41.65%
=======================================
Files 114 114
Lines 17893 17893
=======================================
Hits 7453 7453
Misses 10440 10440
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClementTsang
approved these changes
Sep 3, 2024
|
Thanks for catching this! @all-contributors please add @stephen-huan for code. |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @stephen-huan! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a regression in
btm --theme default-light. Currently,selected_text_styleisWhitewith no background, which causes the text to be borderline unreadable in a white background terminal (see below).This change adds back the
LightBluebackground that was present before the theming changes introduced in #1499.Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)