Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: default config location on macOS considers $XDG_CONFIG_HOME #1570

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 22, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Actually support $XDG_CONFIG_HOME on macOS. Apparently in our docs we also say we do, but we, uh, don't, because dirs doesn't.

Note this is backwards-compatible, in that if a config file exists in the old default locations, we will check those first.

Issue

If applicable, what issue does this address?

Closes: #1569

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41.65%. Comparing base (74ae124) to head (6712e6d).
Report is 2 commits behind head on main.

Files Patch % Lines
src/options.rs 86.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   41.46%   41.65%   +0.19%     
==========================================
  Files         114      114              
  Lines       17840    17893      +53     
==========================================
+ Hits         7398     7454      +56     
+ Misses      10442    10439       -3     
Flag Coverage Δ
macos-12 36.94% <86.66%> (+0.21%) ⬆️
ubuntu-latest 43.38% <0.00%> (-0.06%) ⬇️
windows-2019 36.87% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit a095e67 into main Aug 22, 2024
34 of 36 checks passed
@ClementTsang ClementTsang deleted the xdg_macos branch August 22, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always check $XDG_CONFIG_HOME when initializing the default config on macOS
1 participant