Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CPU widget #157

Merged
merged 13 commits into from
May 17, 2020
Merged

Improve CPU widget #157

merged 13 commits into from
May 17, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented May 16, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

This PR is part one of a change to the CPU widget.

This one focuses on:

  • Removal of the old slash-space-to-hide behaviour of CPU widget

  • Scrolling onto a specific entry will only show that entry

  • Showing average is now default

bottom_cpu_scroll_test

Issue

If applicable, what issue does this address?

Closes: #

Does not close, but part of #156

Type of change

Remove the irrelevant ones:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (if this change causes breakage or new behaviour, please state what)

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang linked an issue May 16, 2020 that may be closed by this pull request
6 tasks
@ClementTsang ClementTsang removed a link to an issue May 17, 2020
6 tasks
@ClementTsang ClementTsang marked this pull request as ready for review May 17, 2020 01:41
@ClementTsang ClementTsang merged commit 12e4777 into master May 17, 2020
@ClementTsang ClementTsang deleted the better_cpu branch May 17, 2020 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant